-
Notifications
You must be signed in to change notification settings - Fork 510
feat: add provider Tailscale #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
atymic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, few minor bits
src/Tailscale/composer.json
Outdated
| "SocialiteProviders\\Tailscale\\": "" | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied composer.json from other providers, which don't have newline. What's the policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a newline
src/Tailscale/composer.json
Outdated
| "docs": "https://socialiteproviders.com/tailscale" | ||
| }, | ||
| "require": { | ||
| "php": "^8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.4 +
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied composer.json from other providers, e.g. Okta. Most of them require 8.0+.
Is there anything 8.4 specific in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, 8.3 is ok. we only support supported php vers
|
Can you please fix the lint error? |
Tailscale now has tsidp: Tailscale OpenID Connect (OIDC) Identity Provider
Instructions on how to set up tsidp for local Tailscale network:
https://github.com/tailscale/tsidp