Draft
Conversation
Open
- Add useFavoriteEvents hook using AsyncStorage for persistence - Update EventSelector to show Favorites section at top with star toggle buttons - Add event.type.favorites localization key to en.json and es.json - Add AsyncStorage jest mock to global test setup - Delete stale EventSelector snapshot for regeneration Agent-Logs-Url: https://github.com/SpeedcuberOSS/speedcuber-timer/sessions/e0a858fc-748a-4bbe-ba7b-0b95bd4452ff Co-authored-by: thehale <47901316+thehale@users.noreply.github.com>
|
|
Copilot
AI
changed the title
[WIP] Add feature to allow users to mark events as favorite
feat: Favorite Events in event switcher
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users had no way to surface preferred events from an ever-growing list, requiring manual scrolling on every selection.
Changes
useFavoriteEventshook (new)AsyncStorageunder@favorite_eventsfavoriteEventIds,isFavorite(id),toggleFavorite(id)[]and reverting optimistic UI updates on write failureEventSelectorIconButtonto every event row (filled = favorited, outline = not)333mbf) render Ticker + star side-by-sideLocalization
event.type.favorites→"Favorites"/"Favoritos"(en + es)Tests
@react-native-async-storage/async-storagejest mock to global setupEventSelectorsnapshot for regeneration