Skip to content

Conversation

@legendarychristian
Copy link
Collaborator

@legendarychristian legendarychristian commented Dec 1, 2025

Added a new scan_directory function that takes in 2 parameters: directory, and recursive_flag. Adding a directory tells the function to scan all the files in the directory and setting the recursive_flag to TRUE allows the function to recursively check all subdirectories within the parent directory.

This resolves #4 and #5. This closes user story #1.

@Speedrunyourknowledge
Copy link
Owner

I fixed a few syntax errors that appeared in the PR checks. I tested the scan_directory function locally, and it works as expected.

Screenshots

Comparing the scan_directory output to the original identify_path output on the tests_data directory

image

Copy link
Owner

@Speedrunyourknowledge Speedrunyourknowledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Speedrunyourknowledge Speedrunyourknowledge changed the title Adding "scan_directory(directory, recursive_flag)" Function Add "scan_directory(directory, recursive_flag)" Function Dec 1, 2025
@Speedrunyourknowledge Speedrunyourknowledge merged commit 2484bfa into main Dec 1, 2025
95 checks passed
@Speedrunyourknowledge Speedrunyourknowledge deleted the feature/scan-directory branch December 1, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design scan_directory helper for Magika Python

4 participants