Fix incomplete unit tests for scan_directory #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The unit test for the scan_directory function in Python was incomplete.
Specifically, the check_results_vs_expected_results function was missing from the test. This function is necessary for asserting that the program produces the expected results.
Implementation
I completed the unit test for scan_directory and added a
tests_data/directoryfolder to be used with the unit test. I also deleted the previously addedtests_data/scan_directoryfolder since it is not needed. Additionally, I updated the scan_directory function to output the scanned files in sorted order because Python's glob module does not guarantee a specific sort order.How This Was Tested
I ran pytest to ensure all the tests pass, including the updated unit test.