Removed download env-file default#35
Open
lmirandacastro wants to merge 1 commit intoSpillwaveSolutions:mainfrom
Open
Removed download env-file default#35lmirandacastro wants to merge 1 commit intoSpillwaveSolutions:mainfrom
lmirandacastro wants to merge 1 commit intoSpillwaveSolutions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the argument parsing in the
scripts/download_confluence.pyscript. The change updates the behavior of the--env-fileargument so that it is now optional and does not default to.env.--env-fileargument in themainfunction to be optional (defaulting toNoneinstead of.env), clarifying that specifying a .env file is now optional, this way if environment variables are set it works.