-
Notifications
You must be signed in to change notification settings - Fork 29
fix: Mobile responsiveness for homepage, submit page, and footer (#37) #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Fix header layout to stack vertically on mobile - Add responsive text sizing for titles and headings - Fix code block overflow with break-words and smaller text - Add responsive padding for step boxes and sub-steps - Fix inline code elements overflow with break-all - Make footer social links stack on mobile - Fix repo link overflow issue (StabilityNexus#37)
WalkthroughUI styling and responsive layout refinements across main pages and footer component. Changes include typography adjustments, padding/margin updates, improved text wrapping, and responsive breakpoint adaptations. No functional logic, routing, or data fetching modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
team name bigbull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/submit/page.tsx (1)
220-224: Consider more selective use ofbreak-allfor inline code.While
break-allprevents overflow, it's applied to all inline code elements including short words like "public", "images", and "articles". Thebreak-allproperty will break words at any character, which can reduce readability unnecessarily for short snippets.Consider applying
break-allonly to longer paths, URLs, and filenames where overflow is likely, while usingbreak-wordsoroverflow-wrap: break-wordfor shorter code snippets:{/* For short words/commands - better readability */} <code className="bg-gray-100 px-1 rounded text-sm">public</code> {/* For long paths/filenames - prevent overflow */} <code className="bg-gray-100 px-1 rounded break-all text-sm">your-article-title.md</code> <code className="bg-gray-100 px-1 rounded break-all text-sm">bitcoin-price-chart.jpg</code>This maintains overflow protection where needed while improving readability for short snippets.
Also applies to: 249-250, 320-322
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/page.tsx(1 hunks)app/submit/page.tsx(20 hunks)components/footer.tsx(1 hunks)
🔇 Additional comments (7)
components/footer.tsx (1)
37-39: LGTM! Responsive footer layout implemented correctly.The responsive flex direction and gap adjustments ensure the footer stacks vertically on mobile devices while maintaining horizontal layout on larger screens. The reduced gap on mobile (gap-3) optimizes space usage.
app/page.tsx (1)
104-117: LGTM! Header responsiveness implemented well.The header properly adapts to mobile viewports with vertical stacking, centered text alignment, and appropriately scaled typography. The
whitespace-nowrapon the submit button is a good touch to maintain button integrity across screen sizes.app/submit/page.tsx (5)
28-32: LGTM! Main container responsive padding implemented correctly.The progressive padding scale (p-4 → sm:p-6 → md:p-12) and title sizing (text-3xl → sm:text-4xl → md:text-5xl) provide appropriate spacing and readability across all viewport sizes.
45-46: LGTM! Responsive section headers and step badges.The use of
flex-shrink-0on icons and step number badges prevents unwanted shrinking on mobile devices, and the responsive sizing ensures readability across breakpoints. This directly addresses the mobile responsiveness requirements in the PR objectives.Also applies to: 98-103, 131-136, 167-172
139-140: LGTM! Code block wrapping handles overflow correctly.The combination of
whitespace-pre-wrapandbreak-wordsensures code blocks wrap on mobile without horizontal overflow while maintaining formatting.Also applies to: 349-350
186-194: Good use ofbreak-allfor long URL.The
break-allclass on the GitHub repository link is appropriate here, as URLs can be quite long and need to wrap on mobile devices to prevent horizontal overflow.
469-527: LGTM! Responsive grid layouts implemented correctly.The Image Guidelines and Submission Guidelines sections properly stack on mobile (grid-cols-1) and expand to two columns on larger screens (md:grid-cols-2), with responsive padding and gap adjustments throughout.
Also applies to: 531-566
Summary
Fixes mobile responsiveness issues across the site, specifically addressing the repo link overflow issue reported in #37.
Changes
Homepage (
/)text-3xl→text-4xl→text-5xlSubmit Page (
/submit)p-4→p-6→p-12)flex-shrink-0whitespace-pre-wrap break-wordsto prevent overflowbreak-all text-smto prevent overflowFooter
Fixes
Testing
Tested on mobile viewport sizes using browser dev tools.
##before
Uploading Monosnap screencast 202
Monosnap.screencast.2025-12-14.00-40-17.1.mp4
5-12-14 00-38-40(1).mp4…
##after
Monosnap.screencast.2025-12-14.00-48-29.1.mp4
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.