-
Notifications
You must be signed in to change notification settings - Fork 100
fix(navigation): address a couple of minor issues #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 55a0641 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mukunku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dancormier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement @giamir 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus state on the selected items (already have an outline) aren't using the 2 px border of the focus ring. I'm assuming there's a conflict with the border that's already there for HC. When in HC, focusing on the vertical items, it feels like the focus disappears when it lands on the selected item.

Can the focus state change to be 2px instead of 1px on selected items that have an outline?
@CGuindon I ended up slightly altering the high contrast mode styles to something that resemble more closely the non-HC mode styles. Please have a look and let me know if it works for you. |
CGuindon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — larger clickable area on the chevron looks good to



SPARK-105
Before the fix