Skip to content

Conversation

@giamir
Copy link
Contributor

@giamir giamir commented Nov 24, 2025

SPARK-105

  • Address an issue where in highcontrast mode anchor navigation items with activity indicator or badges were not correctly underlined. Check out the fix in HC mode
  • Change the background color of the interactive tabs example to be white as the other ones (report)
  • Fix an issue where the trailing story was showing an extra navigation element in the code part
  • Adjust high contrast mode so that focused selected elements are distinguishable (see here for details)
  • Adjust trailing story to use the a button with a larger tappable areas (storybook)
Screenshot 2025-11-24 at 13 31 15

Before the fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

🦋 Changeset detected

Latest commit: 55a0641

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 55a0641
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/69258b944ee70d0008b9ff7c
😎 Deploy Preview https://deploy-preview-2065--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 55a0641
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/69258b94fdea6800089a68a1
😎 Deploy Preview https://deploy-preview-2065--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@giamir giamir changed the base branch from develop to beta November 24, 2025 12:41
@giamir giamir marked this pull request as ready for review November 24, 2025 12:43
Copy link
Collaborator

@mukunku mukunku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underline on hover seems the wrong color but not a big deal:
{4200F15A-A0AA-401D-A270-1767266999C5}

Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement @giamir 🎉

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus state on the selected items (already have an outline) aren't using the 2 px border of the focus ring. I'm assuming there's a conflict with the border that's already there for HC. When in HC, focusing on the vertical items, it feels like the focus disappears when it lands on the selected item.
Screenshot 2025-11-24 at 9 12 17 AM

Screenshot 2025-11-24 at 9 12 24 AM

Can the focus state change to be 2px instead of 1px on selected items that have an outline?

@giamir
Copy link
Contributor Author

giamir commented Nov 25, 2025

The focus state on the selected items (already have an outline) aren't using the 2 px border of the focus ring. I'm assuming there's a conflict with the border that's already there for HC. When in HC, focusing on the vertical items, it feels like the focus disappears when it lands on the selected item. Screenshot 2025-11-24 at 9 12 17 AM

Screenshot 2025-11-24 at 9 12 24 AM Can the focus state change to be 2px instead of 1px on selected items that have an outline?

@CGuindon I ended up slightly altering the high contrast mode styles to something that resemble more closely the non-HC mode styles. Please have a look and let me know if it works for you.
https://deploy-preview-2065--stacks.netlify.app/product/components/navigation/

@giamir giamir requested a review from CGuindon November 25, 2025 11:09
Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — larger clickable area on the chevron looks good to

@giamir giamir merged commit a89da8b into beta Nov 25, 2025
18 checks passed
@giamir giamir deleted the SPARK-105/navigation-fixes branch November 25, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants