Skip to content
This repository was archived by the owner on Mar 26, 2020. It is now read-only.

Conversation

@intel352
Copy link

@intel352 intel352 commented Sep 7, 2012

Affects #2

…fpm listener, added php5-fpm restart, added methods to add database and grant/add user
@StanAngeloff
Copy link
Owner

Looks awesome, I may need to make some tweaks and name changes. Would push a commit likely tomorrow or early next week and would update here with reason behind changes.

@intel352
Copy link
Author

intel352 commented Sep 8, 2012

Sounds great
On Sep 8, 2012 2:02 PM, "Stan Angeloff" notifications@github.com wrote:

Looks awesome, I may need to make some tweaks and name changes. Would push
a commit likely tomorrow or early next week and would update here with
reason behind changes.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-8393562.

@StanAngeloff
Copy link
Owner

I've started looking at the pull and I've stopped at the MySQL and PHP5 functions as I need to learn more on those. I think mysqladmin is more appropriate for issuing commands like creating new databases and users so would be looking at that. As for PHP5-FPM, using sockets for listening is only in 12.04 while the previous LTS uses ports so there needs to be more code to handle both cases.

I'm about to add some comments against your diff for [my] future reference. Leaving pull open until I find more time to roll up the rest of the code.

ubuntu.sh Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-packages-update should be included in the provisioning script to allow for batch updates, e.g., adding several PPAs and doing a single update. I've also updated apt-packages-repository to use add-apt-repository so keep the two functions aligned. See 5b46a36.

StanAngeloff added a commit that referenced this pull request Sep 21, 2012
This commit updates the PHP5-FPM and Nginx configuration functions to
create a new pool instead of modifying the default one. We can control
how this pool is configured, namely we want PHP5-FPM to listen on a Unix
socket which Nginx can connect to.

Tested on Lucid and Precise with PPAs 'nginx/stable' and 'ondrej/php5'.

See #3 for credits and discussion. Thanks @intel352.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants