Skip to content

bugfix: script threw javascript error when response was null #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bugfix: script threw javascript error when response was null #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions twitter/jquery.tweet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
auto_join_text_reply: "i replied to", // [string] auto tense for replies: "i replied to" @someone "with"
auto_join_text_url: "i was looking at", // [string] auto tense for urls: "i was looking at" http:...
loading_text: null, // [string] optional loading text, displayed while tweets load
loading_text_error: 'Sorry, Tweets did not load.', // [string] optional text in case Tweets could not get loaded
refresh_interval: null , // [integer] optional number of seconds after which to reload tweets
twitter_url: "twitter.com", // [string] custom twitter url, if any (apigee, etc.)
twitter_api_url: "api.twitter.com", // [string] custom twitter api url, if any (apigee, etc.)
Expand Down Expand Up @@ -273,16 +274,16 @@
data: { request: build_api_request() },
success: function(data, status) {

if(data.message) {
console.log(data.message);
}

var response = data.response;

$(widget).empty().append(list);
if (s.intro_text) list.before(intro);
list.empty();

if(response.statuses !== undefined) {
if (!response) {
$(widget).html(s.loading_text_error);
return false;
} else if (response.statuses !== undefined) {
resp = response.statuses;
} else if(response.results !== undefined) {
resp = response.results;
Expand All @@ -308,4 +309,4 @@
}).trigger("tweet:load");
});
};
}));
}));