Skip to content

Zircon mem bug fix#2095

Open
mbstrange2 wants to merge 1 commit intomasterfrom
zircon_mem_bug_fix_aha
Open

Zircon mem bug fix#2095
mbstrange2 wants to merge 1 commit intomasterfrom
zircon_mem_bug_fix_aha

Conversation

@mbstrange2
Copy link
Collaborator

Fixed an issue in the Lake port.py code where a port would wait for the next valid token before committing a word to memory. This is unnecessary because the address stream can be observed independently from the data stream.

@steveri
Copy link
Contributor

steveri commented Nov 17, 2025

Hm I see that the gold test is failing....would you like me to fix that for you? The gold model has to be updated to reflect your new changes, and unfortunately that's not as straightforward as it ought to be. But since it's my code, I think it would probably be relatively easier for me to fix it...

@yuchen-mei
Copy link
Collaborator

Hm I see that the gold test is failing....would you like me to fix that for you? The gold model has to be updated to reflect your new changes, and unfortunately that's not as straightforward as it ought to be. But since it's my code, I think it would probably be relatively easier for me to fix it...

Hi Steve, we have discussed and decided to let Max push his fixes to this AHA branch first. Once the Zircon chip is brought up, we will relax the Zircon RTL gold check and merge Max's changes in.

@steveri
Copy link
Contributor

steveri commented Nov 17, 2025

Hm I see that the gold test is failing....would you like me to fix that for you? The gold model has to be updated to reflect your new changes, and unfortunately that's not as straightforward as it ought to be. But since it's my code, I think it would probably be relatively easier for me to fix it...

Hi Steve, we have discussed and decided to let Max push his fixes to this AHA branch first. Once the Zircon chip is brought up, we will relax the Zircon RTL gold check and merge Max's changes in.

Fair enough, that makes sense. So you are freezing the RTL until you are ready to start the next spin on the chip...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants