Skip to content

Add ModalClose component #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ModalClose component #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17344d
Updated: Add bun.lock to .gitignore.
saiful7778 May 5, 2025
4e81403
Updated: Add ModalClose component to DefaultModal and index exports.
saiful7778 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ yarn-debug.log*
yarn-error.log*
yarn.lock
vercel.json
package-lock.json
package-lock.json
bun.lock
5 changes: 4 additions & 1 deletion app/docs/components/modal/variant/DefaultModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
ModalFooter,
ModalHeader,
ModalTitle,
ModalClose,
} from '../../../../src'

const DefaultModal = () => {
Expand All @@ -31,7 +32,9 @@ const DefaultModal = () => {
</div>
</ModalHeader>
<ModalFooter>
<Button variant="outline">Cancel</Button>
<ModalClose asChild>
<Button variant="outline">Cancel</Button>
</ModalClose>
<Button>Confirm</Button>
</ModalFooter>
</ModalContent>
Expand Down
4 changes: 3 additions & 1 deletion app/src/components/Modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use client'
import { Portal, Trigger } from '@radix-ui/react-dialog'
import { Portal, Trigger, Close } from '@radix-ui/react-dialog'
import type { ModalProps } from './Modal'
import { Modal } from './Modal'
import { ModalContent } from './ModalContent'
Expand All @@ -11,6 +11,7 @@ import { ModalTitle } from './ModalTitle'

const ModalAction = Trigger
const ModalPortal = Portal
const ModalClose = Close

export {
Modal,
Expand All @@ -23,4 +24,5 @@ export {
ModalPortal,
ModalProps,
ModalTitle,
ModalClose,
}
Loading