Upgrade skipper click version to latest major #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Dropping support for python 2.7 isn't seamless. |
|
@eranco74 Just a reminder another small company uses this project and still need support for python 2.7 :) |
Contributor
|
@roeigo-stratoscale that small (and amazing) company owns the master branch. |
eranco74
approved these changes
Mar 15, 2023
Since skipper is useful to be installed as a system-level package and not just in a virtualenv, the older click version conflicts with other utilities that use newer version of click (such as Black) This upgrade should fix that conflict. The breaking changes between 6.0 -> 7.0 were changing underscores to dashes by default. Skipper doesn't have any underscores in its subcommands The breaking changes between 7.0 and 8.0 seem to be just dropping support for Python 3.5 and Python 2.7 So I think this upgrade should be rather seamless
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since skipper is useful to be installed as a system-level
package and not just in a virtualenv, the older click version
conflicts with other utilities that use newer version of
click (such as Black)
This upgrade should fix that conflict. The breaking changes
between 6.0 -> 7.0 were changing underscores to dashes by
default. Skipper doesn't have any underscores in its subcommands
The breaking changes between 7.0 and 8.0 seem to be just dropping
support for Python 3.5 and Python 2.7
So I think this upgrade should be rather seamless