Skip to content

Conversation

@aleemstreak
Copy link
Contributor

@aleemstreak aleemstreak commented Nov 21, 2025

Note

Introduce glue tagging across backend and CLI, including deploy-time tags and a new tag command for add/remove/replace.

  • Backend
    • Add tags to CreateGlueParams, UpdateGlueParams, and GlueDTO.
    • Extend createGlue to accept { description, tags } options.
    • New updateGlue(id, params) endpoint client.
  • CLI
    • Deploy: support --tag (collectable); normalize and persist tags on create/update in commands/deploy.ts.
    • New tag command: add/remove/replace tags on one or more glues; supports name args or interactive selection; updates backend via updateGlue.
    • Add multi-select glue picker (askUserForGlues) in commands/common.ts.
    • Register new options/commands in glue.ts.
  • Utils
    • New lib/tagUtils.ts: normalizeTags, addTags, removeTags.

Written by Cursor Bugbot for commit d9288f6. This will update automatically on new commits. Configure here.

@gemini-code-assist
Copy link

Summary of Changes

Hello @aleemstreak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for tagging "glues" within the CLI and backend. It enables users to assign tags to glues during deployment or manage them post-deployment using a new dedicated tag command. This enhancement improves organization and discoverability of glues by allowing them to be categorized with arbitrary labels, making it easier to manage and filter them.

Highlights

  • New CLI tag command: A new command glue tag has been introduced, enabling users to add, remove, or replace tags on one or more glues.
  • Tagging during deployment: The glue deploy command now supports a --tag option, allowing users to assign tags to glues at the time of deployment.
  • Backend API support for tags: The backend API (backend.ts) has been updated to include tags in CreateGlueParams, UpdateGlueParams, and GlueDTO, and new functions createGlue and updateGlue now handle tag data.
  • Interactive glue selection: A new utility function askUserForGlues in commands/common.ts allows interactive selection of multiple glues for operations like tagging.
  • Tag utility functions: A new lib/tagUtils.ts file provides helper functions for normalizing, adding, and removing tags, ensuring consistent tag handling across the application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 21, 2025

Greptile Overview

Greptile Summary

This PR adds tag management functionality to glues, allowing users to add tags during deployment and manage them via a new tag command.

  • Added tags field to GlueDTO, CreateGlueParams, and UpdateGlueParams in backend.ts
  • Created new updateGlue API function for updating glue properties
  • Implemented tag command supporting add, remove, and replace operations
  • Added --tag option to deploy command for setting tags on new/existing glues
  • Created utility functions for tag normalization, addition, and removal

Critical Issues Found:

  • The validation logic in commands/tag.ts:33 uses Set.union() incorrectly, preventing users from adding or removing tags independently
  • Empty array handling in commands/tag.ts:38 will fail when trying to clear all tags with --replace
  • Tag check in commands/deploy.ts:55 is incorrect since normalizeTags returns [] not falsy values

Confidence Score: 1/5

  • This PR contains critical logic bugs that break core functionality
  • Three separate logic errors will cause the tag command to fail in common use cases: adding tags alone won't work, removing tags alone won't work, and clearing all tags won't work. The deploy command will make unnecessary API calls for empty tag arrays.
  • Pay close attention to commands/tag.ts and commands/deploy.ts - both contain logic errors that need fixing

Important Files Changed

File Analysis

Filename Score Overview
commands/tag.ts 1/5 New tag command implementation with critical logic bugs in validation and empty array handling
commands/deploy.ts 2/5 Added tag support to deploy command, but incorrect truthy check on normalized tags array
lib/tagUtils.ts 5/5 Tag utility functions for normalizing, adding, and removing tags - implementation is clean and correct

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new tag command to the CLI for managing tags on glues, and also adds a --tag option to the deploy command. The changes look good overall, but there are a few issues in the new tag command implementation that could lead to unexpected behavior and data loss. I've also identified some areas for performance improvement and code simplification in the new tag utility functions. My detailed feedback is in the comments below.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 18

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@aleemstreak aleemstreak merged commit d0ab885 into master Nov 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants