Feature/migrate profile modal to stellar#266
Open
Mmesolove wants to merge 2 commits intoStreamFi-x:devfrom
Open
Feature/migrate profile modal to stellar#266Mmesolove wants to merge 2 commits intoStreamFi-x:devfrom
Mmesolove wants to merge 2 commits intoStreamFi-x:devfrom
Conversation
- Created StellarWalletProvider context with connection management - Updated ConnectWalletModal to support 5 Stellar wallets (Freighter, xBull, Albedo, Lobstr, Hana) - Removed @starknet-react dependencies from wallet components - Added wallet icons for all supported Stellar wallets - Implemented error handling for wallet not installed, user rejection, and connection failures - Maintained existing UI design and auto-close behavior
- Replace useAccount from @starknet-react/core with useStellarWallet hook - Update registration payload to use Stellar publicKey (G-address format) - Update localStorage/sessionStorage to store Stellar public key - Remove all StarkNet dependencies from ProfileModal component This change enables user registration with Stellar wallet addresses instead of StarkNet hex addresses, maintaining backward compatibility with the /api/users/register endpoint.
|
@Mmesolove is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Hi @Mmesolove, This PR appears to be a duplicate of #263 - both contain identical changes to the same files:
Since #263 has a better conventional commit title ("feat: replace StarkNet with Stellar wallet integration"), could you please close this PR (#266) and keep #263? This will help us avoid confusion and potential merge conflicts. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #issue_number_here
Changes proposed
What were you told to do?
What did you do?
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Closes #266