Skip to content

Comments

feat: add tip tracking columns to users table (#246)#268

Merged
davedumto merged 3 commits intoStreamFi-x:devfrom
romeoscript:feat/add-tip-tracking-columns
Feb 25, 2026
Merged

feat: add tip tracking columns to users table (#246)#268
davedumto merged 3 commits intoStreamFi-x:devfrom
romeoscript:feat/add-tip-tracking-columns

Conversation

@romeoscript
Copy link
Contributor

@romeoscript romeoscript commented Feb 22, 2026

Description

closes #246

Closes #issue_number_here

Changes proposed

What were you told to do?

What did you do?

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

@vercel
Copy link

vercel bot commented Feb 22, 2026

@romeoscript is attempting to deploy a commit to the david's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@davedumto davedumto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Changes Requested

Clean migration implementation that correctly adds all three columns. Only two items need to be addressed.


1. Missing Loom Video (BLOCKING)

Issue #246 requires:

"Loom video submitted showing migration running successfully"

Please record and submit a Loom video showing:

  • The migration script file and its contents
  • Running the migration on your local database
  • Querying the users table to show the new columns exist
  • Showing the default values are set correctly (0 for counters, NULL for last_tip_at)

2. Missing Migration Test (RECOMMENDED)

While not explicitly required, add a simple verification script to ensure the migration works. Example:

# scripts/test-migration.sh
psql $DATABASE_URL -c "\d users" | grep -E "total_tips_received|total_tips_count|last_tip_at"

This helps catch issues before production deployment.


What's Good

✅ All three columns defined correctly with proper types
✅ Default values set appropriately
✅ Column comments added in migration file
✅ Schema file updated
✅ Register endpoint updated
✅ Setup script updated

Once the Loom video is added, this is ready to merge.

@romeoscript
Copy link
Contributor Author

@davedumto davedumto merged commit e6a4853 into StreamFi-x:dev Feb 25, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add database columns for tip tracking

2 participants