feat(types): add StellarPublicKey type and update wallet fields#276
Merged
davedumto merged 1 commit intoStreamFi-x:devfrom Feb 25, 2026
Merged
Conversation
Introduces a StellarPublicKey branded alias (56-char Base32, starts with 'G') and applies it to all wallet fields across User, UserRegistrationInput, UserUpdateInput, FormState, and chat interfaces, replacing the previous plain string type with inline JSDoc documentation.
|
@akintewe is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Loom video needed @akintewe |
Contributor
Author
ok ill send shortly |
Contributor
Author
|
here is the screen recording. @davedumto Screen.Recording.2026-02-25.at.8.57.20.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #241
This PR updates all wallet-related TypeScript type definitions across the
types/directory to reflect the migration from StarkNet hex addresses to Stellar public keys.Changes
types/user.tsStellarPublicKeytype alias (string) with JSDoc documenting the Stellar format (56-character Base32 string starting withG)User.wallet,UserRegistrationInput.wallet, andUserUpdateInput.walletfromstringtoStellarPublicKeywith inline JSDoc commentstypes/settings/profile.tsStellarPublicKeyfrom@/types/userFormState.walletfromstringtoStellarPublicKeywith JSDoc commenttypes/chat.tsStellarPublicKeyfrom@/types/userChatMessageAPI.user.wallet,ChatMessage.wallet, andSendChatMessagePayload.walletfromstringtoStellarPublicKeywith JSDoc commentstypes/explore/,types/landing-page/Acceptance Criteria
StellarPublicKeytype alias created and exported fromtypes/user.tsUser.wallettyped asStellarPublicKeywith JSDocUserRegistrationInput.wallettyped asStellarPublicKeyUserUpdateInput.wallettyped asStellarPublicKey0x, hex) in any type definitionstypes/directory consistently documentednpm run type-checkpasses — dependencies not installed in this environment; please verify locally withnpm install && npm run type-check