Skip to content

chore(deps): upgrade @eslint/js to v10 with lint fixes#134

Merged
StuMason merged 3 commits intomainfrom
chore/eslint-v10-upgrade
Feb 26, 2026
Merged

chore(deps): upgrade @eslint/js to v10 with lint fixes#134
StuMason merged 3 commits intomainfrom
chore/eslint-v10-upgrade

Conversation

@StuMason
Copy link
Owner

Summary

  • Bumps @eslint/js from 9.39.3 to 10.0.1 (from dependabot PR chore(deps): bump @eslint/js from 9.39.3 to 10.0.1 #133)
  • Fixes new preserve-caught-error rule violations by adding { cause: error } to re-thrown errors in coolify-client.ts
  • Bumps tsconfig target from ES2020 to ES2022 to support ErrorOptions type

Closes #133

Test plan

  • npm run lint — 0 errors (4 pre-existing warnings only)
  • npm run build — compiles cleanly
  • npm test — 262 tests pass, 3 suites pass

dependabot bot and others added 2 commits February 26, 2026 10:00
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.39.3 to 10.0.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/commits/v10.0.1/packages/js)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-version: 10.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Add { cause: error } to re-thrown errors in coolify-client.ts and bump
tsconfig target to ES2022 to support ErrorOptions type.
@claude
Copy link

claude bot commented Feb 26, 2026

PR Review: chore(deps): upgrade @eslint/js to v10 with lint fixes

Thanks for this PR! Overall this looks like a clean and well-executed dependency upgrade. Here is my review:

✅ Code Quality

Error Handling Improvements (src/lib/coolify-client.ts)

  • Adding { cause: error } to re-thrown errors is an excellent practice. This preserves the original error stack trace, making debugging much easier.
  • The implementation is clean and minimal.

TypeScript Target Bump (tsconfig.json)

  • Bumping to ES2022 is the correct approach since ErrorOptions (the second argument to Error()) requires ES2022+.
  • ES2022 is well-supported in Node 18+, which matches the project engine requirements.

⚠️ Potential Compatibility Concern

Node.js Version Mismatch

The @eslint/js v10 package requires:

node: ^20.19.0 || ^22.13.0 || >=24

However, package.json has:

engines: { node: ">=18" }

Since @eslint/js is a devDependency, this will not affect end users, but contributors on Node 18 or 19 may encounter issues during development. Consider one of:

  1. Updating the engines field to >=20 to align with ESLint v10 requirements
  2. Adding a note to the README about the minimum Node version for development
  3. Accepting this as-is since most developers are likely on Node 20+ by now

This is a minor concern given the devDependency nature - not a blocker.

✅ Test Coverage

Per the PR description:

  • npm run lint — passes (only pre-existing warnings)
  • npm run build — compiles cleanly
  • npm test — 262 tests pass

No new code requiring test coverage was added; this is purely a lint rule compliance fix.

✅ Security

No security concerns. This is a standard dependency upgrade with appropriate error handling improvements.

✅ Documentation

No documentation updates required for this change.


Verdict: Approve 👍

The changes are clean, well-tested, and improve error debugging capabilities. The Node.js version mismatch is minor and only affects development environments. Nice work keeping dependencies up to date!

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.18%. Comparing base (6f3ef3f) to head (22c9a22).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files           2        2           
  Lines         488      488           
  Branches      127      127           
=======================================
  Hits          445      445           
  Misses         11       11           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StuMason StuMason merged commit 5bc63e8 into main Feb 26, 2026
6 checks passed
@StuMason StuMason deleted the chore/eslint-v10-upgrade branch February 26, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant