Open
Conversation
Member
|
Please don't merge into ticket branches. Do you need help rebasing? |
Member
Author
I accidentally pushed it, sorry. |
dobos
force-pushed
the
tickets/DAMD-162
branch
from
64b2255 to
14bd065
Compare
dobos
force-pushed
the
tickets/DAMD-162
branch
from
4e160c4 to
b266181
Compare
dobos
force-pushed
the
tickets/DAMD-162
branch
from
528bc1e to
a226a9f
Compare
dobos
force-pushed
the
tickets/DAMD-162
branch
from
a226a9f to
bbbd7d5
Compare
…ellar params to the catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GA data model is designed a bit more generic in order to accommodate an arbitrary number of measured parameters, potentially measured using several different methods, although the current plan is to use a single method only. We extended the FluxTable class in GAFluxTable with additional columns as we are going to provide a best fit template to the spectra, as well as a flux-recalibrated coadded spectrum.
Using a different FluxTable class for PfsGAObject required minor modifications to FluxTable itself and PfsFiberArray to allow for instantiating different types of flux tables.
The unit tests complete successfully including flake8.