PIPE2D-1000: Revert all arrays except wavelengths from double to single precision float#269
Open
PaulPrice wants to merge 2 commits intotickets/PIPE2D-506from
Open
PIPE2D-1000: Revert all arrays except wavelengths from double to single precision float#269PaulPrice wants to merge 2 commits intotickets/PIPE2D-506from
PaulPrice wants to merge 2 commits intotickets/PIPE2D-506from
Conversation
hassanxp
approved these changes
May 4, 2022
PaulPrice
force-pushed
the
tickets/PIPE2D-506
branch
from
f5ead1a to
7e3852c
Compare
PaulPrice
force-pushed
the
tickets/PIPE2D-1000
branch
from
228ecc3 to
a4735f5
Compare
PaulPrice
force-pushed
the
tickets/PIPE2D-506
branch
from
7e3852c to
594775c
Compare
Wavelength needs to be in double precision in order to preserve the precision in the measurements, but other quantities (esp. flux) don't need double precision, and datamodel I/O has been reverted to single-precision for these to save disk space. This commit adapts to these changes.
PaulPrice
force-pushed
the
tickets/PIPE2D-1000
branch
from
a4735f5 to
9ad278a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.