Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new database indexes to the
fluxstdtable to improve query performance and updates the corresponding model and documentation. Additionally, a minor logging improvement is made in the utility function for target dataframes.Database Index Additions:
fluxstdtable: one oninput_catalog_idandfluxstd_id, and another onversionandfluxstd_id, to optimize query efficiency. (alembic/pfsa-db01-gb/alembic/versions/20251216-182855_385b6cdf44f7_add_indexes_to_fluxstd.py)fluxstdto include the new indexes, ensuring consistency between the codebase and database schema. (src/targetdb/models/fluxstd.py)docs/tbls/public.fluxstd.md)Code Quality Improvement:
make_target_df_from_uploaderutility function by using f-string formatting for clarity. (src/targetdb/utils.py)