make an outgoing column in the report for cleanses/healing/barrier

[rigel314]

Cleanses don't include CondiCleanseSelf, so this PR skips adding healing and barrier with the same source and destination player.

The main players list should be in the same order the outgoingHealingAllies/outgoingBarrierAllies arrays, so this PR just adds an if statement that skips adding healing/barrier if the player index matches healing/barrier index.

[Swedemon]

Thanks for the PR. My first thought is self healing would be included. I wasn't aware that Self cleanses are excluded. Are you aware of a fix to include self cleanses?

[rigel314]

The json report from EI splits cleanses into "condiCleanse" and "condiCleanseSelf" fields.

You could add them together around here:
https://github.com/Swedemon/MzFightReporter/blob/master/src/main/java/org/vmy/ParseBot.java#L195

[rigel314]

Maybe it would be good to show totals and "outgoing only" in the report.

[Swedemon]

I can certainly add them. Where did you discover that condiCleanse excludes self, is that in the EI docs somewhere?

[rigel314]

Huh, I assumed that plenbot was doing the right thing here: https://github.com/Plenyx/PlenBotLogUploader/blob/e7affb563c33ff15cccfafc90bc1dbbda1da6c55/DpsReport/ExtraJSON/PlayerSupport.cs#L13

internal int CondiCleanseTotal => CondiCleanse + CondiCleanseSelf;

But also now that I've double checked EI, these comments seem to indicate that "condiCleanse" wouldn't include self cleanses which seems to mean that plenbot is correct:
https://github.com/baaron4/GW2-Elite-Insights-Parser/blob/bbbbfde779064255931434f09d6b97f170f3a698/GW2EIJSON/JsonActorUtilities/JsonStatistics.cs#L491-L504

        /// <summary>
        /// Number of time a condition was cleansed on a squad mate
        /// </summary>
        public long CondiCleanse;

        // ...

        /// <summary>
        /// Number of time a condition was cleansed from self
        /// </summary>
        public long CondiCleanseSelf;

[Swedemon]

Very good, I will follow suit when I get a window.

[rigel314]

I updated the PR to add an "outgoing" column to the reports for healing, barrier, and cleanses. I didn't change any sorting, so everything should still be sorted by the total.

[Swedemon]

Is that change to separate self versus squad number and display both?

[rigel314]

Pretty much that. I made it keep track of total and "excluding self" separately. So for cleanses, it displays (CondiCleanse + CondiCleanseSelf) and (CondiCleanse) in separate columns.

It ends up looking like this:

Cleanses:
 #  Player           Total Outgoing CPS
--- -------------------- ---- ---- ----
 1  Player 28       TEMP 1229 1030 2.22
 2  Player 4        DRUI 1218 1099 2.20
 3  Player 39       SCRA 1152 1036 2.08
 4  Player 12       TEMP 1113  918 2.01
 5  Player 22       TEMP  966  831 1.74
 6  Player 18       DRUI  840  744 1.52
 7  Player 31       SCRA  656  583 1.18
 8  Player 37       TEMP  544  440 0.98
 9  Player 42       TEMP  419  377 0.76
10  Player 14       CHRO  416  349 0.75


Heals & Barrier (heal addon required):
 #  Player           Heals Outgoing HPS
--- ----------------- ----- ----- -----
 1  Player 18    DRUI 1.42m 1.33m  2.6k
 2  Player 4     DRUI 1.19m 1.12m  2.1k
 3  Player 28    TEMP  820k  660k  1.5k
 4  Player 7     SCRA  275k  258k   495
 5  Player 6     FIRE   94k   66k   169

 #  Player         Barrier Outgoing BPS
--- ----------------- ----- ----- -----
 1  Player 7     SCRA  294k  243k   528
 2  Player 3     REAP  275k     0   494
 3  Player 5     CHRO   98k   87k   176
 4  Player 4     DRUI   43k     0    78
 5  Player 18    DRUI   22k     0    39

[Swedemon]

It's an idea I just don't want to add a stat to separate personal versus squad healing/cleanses. Keep me posted if you have other ideas.