Use the PHPUnit Exporter util class #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
force-pushed
the
exporter-compat
branch
from
f307729 to
b3400a3
Compare
Member
|
Thank you. I have rebased your PR. I also made sure that you can merge your own PR now if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #159
Fixes #158
PHPUnit 10.5, 11.3-11.5, and 12.0 all have a
PHPUnit\Util\Exporterclass which proxies to thesebastian/exporterpackage. It is deprecated in 10.5, removed from 11.0, and restored in 11.3. To avoid the issue reported in #158, this PR makes use of that utility class and removes the direct uses of and dependency tosebastian/exporter.I've also bumped the minimum PHPUnit version for the 11.x branch to 11.5 because at this point the older branches are unsupported so not having to deal with differing behavior in the 3 minor versions this class doesn't exist in seems like a win.