Feat/futures #122
Feat/futures #122
Conversation
dbeal-eth
left a comment
dbeal-eth
left a comment
There was a problem hiding this comment.
very nice 👍 only minor things to confirm
|
|
||
| export function handlePositionModified(event: PositionModifiedEvent): void { | ||
| let futuresMarketContract = FuturesMarketContract.bind(event.transaction.to as Address); | ||
| let proxyAddress = futuresMarketContract.proxy(); |
There was a problem hiding this comment.
seems really expensive to run a contract call here in order to set an ID... isn't there a better way to do this, such as using the FuturesMarketEntity asset instead?
There was a problem hiding this comment.
yeah problem is the event doesn't emit the asset. And the from address is the underlying contract, which means we need to retrieve the proxy address first so we can match the position entity with the market one :(
| margin: BigInt! | ||
| entryPrice: BigInt! | ||
| exitPrice: BigInt | ||
| } |
There was a problem hiding this comment.
might want to add entities to track position histories as well (it can simply be a convenient store of events which can be displayed on a "Trading History" page or something)
There was a problem hiding this comment.
It kinda is already since we have an ID, which comes from the contract. Every different ID is a new position. So calling this entity by account or timestamp will give us a history
Cumulative futures stats
Add timestamp to minute stat
Assign timestamp
Rename averageVolume to averageTradeSize
Cumulative stats by market
|
can this PR be closed? the changes should be pushed to the |
Feat/futures competition
No description provided.