Skip to content

[#13498] Remove "archive courses" back-end logic#13533

Merged
mingyuancode merged 5 commits intoTEAMMATES:chore/remove-archive-course-featurefrom
TobyCyan:fix-13498-remove-archive-courses-back-end
Feb 12, 2026
Merged

[#13498] Remove "archive courses" back-end logic#13533
mingyuancode merged 5 commits intoTEAMMATES:chore/remove-archive-course-featurefrom
TobyCyan:fix-13498-remove-archive-courses-back-end

Conversation

@TobyCyan
Copy link
Copy Markdown
Contributor

@TobyCyan TobyCyan commented Feb 11, 2026

Part of #13498

Outline of Solution

  • Removed course archival from logic and entity classes.
  • Removed archive field data migration class.
  • Updated tests.

Fork #PR for CI proof.

Front-end Demo

TEAMMATES_PR_FRONTEND_DEMO.mp4

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the remaining back-end pieces of the “archive courses” feature (endpoint, request/output types, datastore persistence/logic, and related constants), aligning with the staged removal plan in #13498 after front-end disconnection.

Changes:

  • Deleted the course-archival WebAPI endpoint (ArchiveCourseAction) and its request/output DTOs.
  • Removed datastore-level isArchived handling from the Instructor entity and instructor retrieval/update logic.
  • Updated affected WebAPI flows and tests to use the simplified instructor retrieval API and removed archived course status handling.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/java/teammates/ui/webapi/GetActionClassesActionTest.java Removes ArchiveCourseAction from the expected action class list.
src/test/java/teammates/ui/webapi/BinCourseActionTest.java Updates instructor retrieval call signature in test.
src/test/java/teammates/storage/api/InstructorsDbTest.java Updates tests for getInstructorsForGoogleId new signature.
src/test/java/teammates/sqlui/webapi/GetActionClassesActionTest.java Removes ArchiveCourseAction import and expectation.
src/test/java/teammates/common/datatransfer/attributes/InstructorAttributesTest.java Updates datastore Instructor constructor usage after removing isArchived.
src/main/java/teammates/ui/webapi/GetFeedbackSessionsAction.java Uses simplified instructor retrieval (no archived filtering).
src/main/java/teammates/ui/webapi/GetCoursesAction.java Removes archived course status branch and updates instructor retrieval accordingly.
src/main/java/teammates/ui/webapi/ArchiveCourseAction.java Deletes the archive-course endpoint implementation.
src/main/java/teammates/ui/webapi/ActionFactory.java Unmaps the course archive endpoint route.
src/main/java/teammates/ui/request/CourseArchiveRequest.java Deletes request body type for course archival.
src/main/java/teammates/ui/output/CourseArchiveData.java Deletes response DTO for course archival.
src/main/java/teammates/ui/constants/ResourceEndpoints.java Removes COURSE_ARCHIVE endpoint enum entry.
src/main/java/teammates/storage/entity/Instructor.java Removes datastore isArchived field and related accessors/constructor param.
src/main/java/teammates/storage/api/InstructorsDb.java Removes archived filtering/support from instructor queries and updates.
src/main/java/teammates/sqllogic/core/FeedbackSessionsLogic.java Updates Javadoc to remove archived-course omission mention.
src/main/java/teammates/sqllogic/api/Logic.java Updates Javadoc to remove archived-course omission mention.
src/main/java/teammates/logic/core/InstructorsLogic.java Removes archival setter and consolidates instructor retrieval API.
src/main/java/teammates/logic/core/FeedbackSessionsLogic.java Updates Javadoc to remove archived-course omission mention.
src/main/java/teammates/logic/core/AccountsLogic.java Updates instructor retrieval call signature.
src/main/java/teammates/logic/api/Logic.java Removes archived-aware instructor retrieval overload and archive setter API.
src/main/java/teammates/common/util/Const.java Removes archived course status and course archive URI constants.
src/main/java/teammates/common/datatransfer/attributes/InstructorAttributes.java Removes isArchived from datastore instructor attributes and update options.
src/client/java/teammates/client/scripts/DataMigrationForInstructorNullIsArchivedField.java Deletes obsolete migration script for isArchived null handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@mingyuancode mingyuancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuancode mingyuancode merged commit 9043fd6 into TEAMMATES:chore/remove-archive-course-feature Feb 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants