Skip to content

‘)’ ⇒ ‘>’ for LaTeX newcolumntype #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sydb wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

‘)’ ⇒ ‘>’ for LaTeX newcolumntype #772

sydb wants to merge 2 commits into from

Conversation

@sydb
Copy link
Member

@sydb sydb commented Sep 1, 2025

Per suggestion @jlq-foss change ‘)’ to ‘>’ wherever it occurs (which, it turns out, is 6 places in a row in latex/latex_param.xsl). This is in order to address #771.

I have it passing both Test/ and Test2/, so I know it doesn’t fail, but I do not have sufficient LaTeX knowledge nor capability to actually test that it works.

@sydb
Per suggestion @jlq-foss change
052303f 
‘)’ to ‘>’ wherever it occurs (which, it turns out, is 6 places
in a row in latex/latex_param.xsl). This is in order to address
#771.
@sydb sydb added this to the Release 7.60.0 milestone Sep 1, 2025
@sydb sydb requested a review from torstenroeder September 1, 2025 04:22
@joeytakeda
Copy link
Contributor

joeytakeda commented Nov 25, 2025 •
edited
Loading

I don't know latex at all, but running xelatex actual-results/test.tex in this branch (in Docker) produces a number of errors (pasted below). But accepting all of the errors, it does create a PDF that is different from dev (compare p. 8; section 8 "Tables") -- attached below. (Though not entirely sure what they were supposed to look like to begin with)

test-pr-772.pdf
test-dev.pdf

Output of `xelatex actual-results/test.tex` 
oot@d5aee22fed13:/tei/Stylesheets/Test# xelatex actual-results/test.tex
This is XeTeX, Version 3.14159265-2.6-0.999992 (TeX Live 2020/Debian) (preloaded format=xelatex)
 restricted \write18 enabled.
entering extended mode
(./actual-results/test.tex
LaTeX2e <2020-10-01> patch level 4
L3 programming layer <2021-01-09> xparse <2020-03-03>
(/usr/share/texlive/texmf-dist/tex/latex/base/article.cls
Document Class: article 2020/04/10 v1.4m Standard LaTeX document class
(/usr/share/texlive/texmf-dist/tex/latex/base/size11.clo))
(/usr/share/texlive/texmf-dist/tex/latex/xcolor/xcolor.sty
(/usr/share/texlive/texmf-dist/tex/latex/graphics-cfg/color.cfg)
(/usr/share/texlive/texmf-dist/tex/latex/graphics-def/xetex.def))
(/usr/share/texlive/texmf-dist/tex/latex/colortbl/colortbl.sty
(/usr/share/texlive/texmf-dist/tex/latex/tools/array.sty))
(/usr/share/texlive/texmf-dist/tex/latex/wrapfig/wrapfig.sty)
(/usr/share/texlive/texmf-dist/tex/generic/iftex/ifxetex.sty
(/usr/share/texlive/texmf-dist/tex/generic/iftex/iftex.sty))
(/usr/share/texlive/texmf-dist/tex/latex/fontspec/fontspec.sty
(/usr/share/texlive/texmf-dist/tex/latex/l3packages/xparse/xparse.sty
(/usr/share/texlive/texmf-dist/tex/latex/l3kernel/expl3.sty
(/usr/share/texlive/texmf-dist/tex/latex/l3backend/l3backend-xetex.def
(|extractbb --version)))
(/usr/share/texlive/texmf-dist/tex/latex/l3packages/xparse/xparse-generic.tex))
(/usr/share/texlive/texmf-dist/tex/latex/fontspec/fontspec-xetex.sty
(/usr/share/texlive/texmf-dist/tex/latex/base/fontenc.sty)
(/usr/share/texlive/texmf-dist/tex/latex/fontspec/fontspec.cfg)))
(/usr/share/texlive/texmf-dist/tex/xelatex/xunicode/xunicode.sty
(/usr/share/texmf/tex/latex/tipa/t3enc.def)
(/usr/share/texlive/texmf-dist/tex/latex/graphics/graphicx.sty
(/usr/share/texlive/texmf-dist/tex/latex/graphics/keyval.sty)
(/usr/share/texlive/texmf-dist/tex/latex/graphics/graphics.sty
(/usr/share/texlive/texmf-dist/tex/latex/graphics/trig.sty)
(/usr/share/texlive/texmf-dist/tex/latex/graphics-cfg/graphics.cfg))))
(/usr/share/texlive/texmf-dist/tex/latex/relsize/relsize.sty)
(/usr/share/texlive/texmf-dist/tex/latex/geometry/geometry.sty
(/usr/share/texlive/texmf-dist/tex/generic/iftex/ifvtex.sty))
(/usr/share/texlive/texmf-dist/tex/latex/framed/framed.sty)
(/usr/share/texlive/texmf-dist/tex/latex/tools/longtable.sty)
(/usr/share/texlive/texmf-dist/tex/generic/ulem/ulem.sty)
(/usr/share/texlive/texmf-dist/tex/latex/fancyvrb/fancyvrb.sty)
(/usr/share/texlive/texmf-dist/tex/latex/fancyhdr/fancyhdr.sty)
(/usr/share/texlive/texmf-dist/tex/latex/marginnote/marginnote.sty)
(/usr/share/texlive/texmf-dist/tex/latex/endnotes/endnotes.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/hyperref.sty
(/usr/share/texlive/texmf-dist/tex/generic/ltxcmds/ltxcmds.sty)
(/usr/share/texlive/texmf-dist/tex/generic/pdftexcmds/pdftexcmds.sty
(/usr/share/texlive/texmf-dist/tex/generic/infwarerr/infwarerr.sty))
(/usr/share/texlive/texmf-dist/tex/generic/kvsetkeys/kvsetkeys.sty)
(/usr/share/texlive/texmf-dist/tex/generic/kvdefinekeys/kvdefinekeys.sty)
(/usr/share/texlive/texmf-dist/tex/generic/pdfescape/pdfescape.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hycolor/hycolor.sty)
(/usr/share/texlive/texmf-dist/tex/latex/letltxmacro/letltxmacro.sty)
(/usr/share/texlive/texmf-dist/tex/latex/auxhook/auxhook.sty)
(/usr/share/texlive/texmf-dist/tex/latex/kvoptions/kvoptions.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/pd1enc.def)
(/usr/share/texlive/texmf-dist/tex/generic/intcalc/intcalc.sty)
(/usr/share/texlive/texmf-dist/tex/generic/etexcmds/etexcmds.sty)

Package hyperref Warning: XeTeX driver only supports unicode.
(hyperref)                Enabling option `unicode'.

(/usr/share/texlive/texmf-dist/tex/latex/hyperref/puenc.def)
(/usr/share/texlive/texmf-dist/tex/latex/url/url.sty)
(/usr/share/texlive/texmf-dist/tex/generic/bitset/bitset.sty
(/usr/share/texlive/texmf-dist/tex/generic/bigintcalc/bigintcalc.sty))
(/usr/share/texlive/texmf-dist/tex/latex/base/atbegshi-ltx.sty))
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/hxetex.def
(/usr/share/texlive/texmf-dist/tex/generic/stringenc/stringenc.sty)
(/usr/share/texlive/texmf-dist/tex/latex/rerunfilecheck/rerunfilecheck.sty
(/usr/share/texlive/texmf-dist/tex/latex/base/atveryend-ltx.sty)
(/usr/share/texlive/texmf-dist/tex/generic/uniquecounter/uniquecounter.sty)))
(./test.aux) (/usr/share/texlive/texmf-dist/tex/latex/base/ts1cmr.fd)
(/usr/share/texmf/tex/latex/tipa/t3cmr.fd)
*geometry* driver: auto-detecting
*geometry* detected driver: xetex
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/nameref.sty
(/usr/share/texlive/texmf-dist/tex/latex/refcount/refcount.sty)
(/usr/share/texlive/texmf-dist/tex/generic/gettitlestring/gettitlestring.sty))
(./test.out) (./test.out) [1] [1]

Package marginnote Warning: Consecutive odd pages found.
(marginnote)                Note, it is not recommended to use consecutive
(marginnote)                odd pages in a double-ended document.
(marginnote)                The pages of your document should always
(marginnote)                be a sequence: odd-even-odd-even-...
(marginnote)                Maybe you've forgotten a \cleardoublepage before
(marginnote)                changing the page numbering on page i.

[2] [3] [4]

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.360 ...extwidth}P{0.6582429501084599\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.360 ...extwidth}P{0.6582429501084599\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.360 ...extwidth}P{0.6582429501084599\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.360 ...extwidth}P{0.6582429501084599\textwidth}}
                                                  
? 

LaTeX Font Warning: Font shape `TU/lmr/bx/scit' undefined
(Font)              using `TU/lmr/bx/sc' instead on input line 379.


LaTeX Font Warning: Font shape `TU/lmr/bx/sc' undefined
(Font)              using `TU/lmr/bx/n' instead on input line 379.


Underfull \vbox (badness 10000) detected at line 379

Overfull \hbox (123.9646pt too wide) in paragraph at lines 386--386
[][][]\TU/lmr/m/n/9 We start with a quotation: []
[1]

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.428 ...xtwidth}P{0.09097859327217125\textwidth}}
                                                  
? 

Overfull \hbox (131.1621pt too wide) in alignment at lines 429--434
 [] [] [] [] [] [] [] [] [] 
[2]

Package longtable Warning: Column widths have changed
(longtable)                in table 2 on input line 434.


! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.436 ...twidth}P{0.010429447852760737\textwidth}}
                                                  
? 

Package longtable Warning: Column widths have changed
(longtable)                in table 3 on input line 446.

[3]
Underfull \hbox (badness 10000) in paragraph at lines 473--474
[] 

Underfull \hbox (badness 10000) in paragraph at lines 473--474


Underfull \hbox (badness 10000) in paragraph at lines 482--483
[] 

Underfull \hbox (badness 10000) in paragraph at lines 482--483


! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.490 ...extwidth}P{0.6519826517967782\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.490 ...extwidth}P{0.6519826517967782\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (>): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.490 ...extwidth}P{0.6519826517967782\textwidth}}
                                                  
? 

! Package array Error:  Illegal pream-token (\arraybackslash): `c' used.

See the array package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.490 ...extwidth}P{0.6519826517967782\textwidth}}
                                                  
? 

Overfull \hbox (82.5715pt too wide) in alignment at lines 490--501
 [] [] [] [] [] [] 
[4] [5] [6] [7]
Underfull \vbox (badness 10000) has occurred while \output is active [8]
Underfull \vbox (badness 10000) has occurred while \output is active [9]
[10]

! LaTeX Error: Something's wrong--perhaps a missing \item.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.614 {</\textbf{div}>}\end{shaded}
                                   \egroup\par
? 
[11]
Overfull \hbox (236.33923pt too wide) in paragraph at lines 617--625
| \TU/DejaVuSansMono(0)/m/n/9 <\TU/DejaVuSansMono(0)/b/n/9 seg\TU/DejaVuSansMon
o(0)/m/n/9 >Fit the first @ <\TU/DejaVuSansMono(0)/b/n/9 ref| \TU/DejaVuSansMon
o(0)/m/n/9 target="http://www.example.com/?foo=bar&bar=foo&#3">http://www.examp
le.com/?foo=bar&bar=foo&#3</\TU/DejaVuSansMono(0)/b/n/9 ref\TU/DejaVuSansMono(0
)/m/n/9 >[] 

LaTeX Warning: Reference `s' on page 12 undefined on input line 626.

(./test.ent)

Package longtable Warning: Table widths have changed. Rerun LaTeX.

[12] (./test.aux)

LaTeX Font Warning: Some font shapes were not available, defaults substituted.


LaTeX Warning: There were undefined references.

 )

@martindholmes
Copy link
Contributor

martindholmes commented Nov 26, 2025

I'm a little wary of the idea that we might be changing Sebastian's LaTeX (he literally wrote books on it) when we don't quite understand what the difference between the two formulations is. I can't find any examples using the parenthesis, but also, when I look at the differences between the two files as linked by @joeytakeda above, I can't tell which is better. I'd like a clearer explanation of what's going on here. Why does the processor not raise an error with the existing formulation, if it's wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torstenroeder torstenroeder Awaiting requested review from torstenroeder

Assignees

@bleekere bleekere

Labels

conversion: latex type: bug A bug report.

Projects

None yet

Milestone

Release 7.60.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sydb @joeytakeda @martindholmes @bleekere