Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Extract all 8 database drivers into .tableplugin bundles loaded at runtime. Add Settings > Plugins tab for managing installed plugins.
datlechin
force-pushed
the
feat/plugin-system
branch
from
0681cf3 to
f642a44
Compare
- Fix data race: remove nonisolated(unsafe) from driverPlugins, make DatabaseDriverFactory @mainactor - Fix blocking thread: replace process.waitUntilExit() with async continuation - Fix signature check: pin to team ID via SecRequirement instead of accepting any cert - Fix unregisterCapabilities: remove additionalDatabaseTypeIds entries (e.g., MariaDB) - Fix minAppVersion error: use new appVersionTooOld case with correct parameters - Fix default switchDatabase: throw unsupported error instead of T-SQL syntax - Fix PluginsSettingsView: use SwiftUI .alert instead of unreliable NSApp.keyWindow - Remove redundant testConnection override from PluginDriverAdapter - Add MySQL-specific switchDatabase override with backtick escaping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tablepluginbundles loaded at runtime byPluginManagerTableProPluginKitshared framework withDriverPlugin,PluginDatabaseDriver, and transfer typesPluginDriverAdapterbridging plugin drivers to the app'sDatabaseDriverprotocolfatalErrorinDatabaseDriverFactory.createDriverwith thrown error to prevent crashes when plugins aren't loadedTest plan