Skip to content

fix: position popovers using table view geometry instead of cell view bounds#211

Merged
datlechin merged 1 commit intomainfrom
fix/enum-popover-positioning
Mar 9, 2026
Merged

fix: position popovers using table view geometry instead of cell view bounds#211
datlechin merged 1 commit intomainfrom
fix/enum-popover-positioning

Conversation

@datlechin
Copy link
Copy Markdown
Collaborator

Summary

  • Fix enum dropdown (and all other cell popovers) appearing at wrong position instead of near the clicked cell
  • Replace cellView.bounds/cellView anchoring with tableView.rect(ofRow:).intersection(tableView.rect(ofColumn:)) anchoring to tableView
  • Cell views can be recycled/relaid-out during click processing, making their bounds unreliable for popover positioning

Closes #209

Test plan

  • Click an enum column cell — popover should appear directly below/above the cell
  • Click a SET column cell — same positioning behavior
  • Double-click a date column — date picker popover near the cell
  • Double-click a FK column — FK popover near the cell
  • Double-click a JSON column — JSON editor near the cell
  • Test with scrolled table (rows not at top) — popover still anchored correctly

… bounds

Fixes #209. Cell views can be recycled/relaid-out during click processing,
causing popovers to appear at incorrect positions (e.g. window center).
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin datlechin self-assigned this Mar 9, 2026
@datlechin datlechin merged commit fa6a4d0 into main Mar 9, 2026
1 check passed
@datlechin datlechin deleted the fix/enum-popover-positioning branch March 9, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: enum dropdown does not show up near the edited field

1 participant