fix: close SSH tunnels on window close and app termination#217
Merged
fix: close SSH tunnels on window close and app termination#217
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
c1ebc9d to
ba9a6c2
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #214 — SSH tunnel processes (
ssh -N -L) were not terminated when closing a connection window or quitting the app.Four root causes fixed:
disconnectSession()was SwiftUI'sonDisappear, which can miss window closes. NowWindowLifecycleMonitorposts.lastWindowDidCloseviaNSWindow.willCloseNotification(always fires), andDatabaseManagerobserves it as a deterministic disconnect path.applicationWillTerminatenow callsSSHTunnelManager.terminateAllProcessesSync()to kill all SSH processes before exit.waitForProcessExitcould hang forever: If the SSH process exited betweenterminate()and settingterminationHandler, the continuation never resumed. Now guardsisRunning, races termination handler vs timeout viaTaskGroup, and SIGKILLs as fallback.closeAllTunnels()didn't wait: Now waits for all processes concurrently viaTaskGroup.Test plan
lsof -i | grep ssh— confirm tunnel process existslsof -i | grep ssh— confirm tunnel process is gone