Skip to content

feat: add shared PluginKit types#257

Merged
datlechin merged 1 commit intomainfrom
feat/plugin-kit-shared-types
Mar 10, 2026
Merged

feat: add shared PluginKit types#257
datlechin merged 1 commit intomainfrom
feat/plugin-kit-shared-types

Conversation

@datlechin
Copy link
Copy Markdown
Collaborator

@datlechin datlechin commented Mar 10, 2026

Summary

  • Add 3 untracked TableProPluginKit files that were created during Phase 1 plugin standardization but never committed
  • PluginDriverError.swift — shared error protocol for plugin drivers
  • PluginConcurrencySupport.swift — async bridging utility
  • PluginRowLimits.swift — shared row limit constant

Test plan

  • Xcode build passes with no errors
  • Verify plugin loading works at runtime

Summary by CodeRabbit

  • New Features
    • Added async/await support utilities for plugin developers to execute code on specified dispatch queues
    • Introduced a standardized error protocol for plugins with consistent error messaging and optional error codes
    • Defined default row limit configuration for plugin data handling

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Three new Swift utility files are added to TableProPluginKit: concurrency support for async/await dispatching, a protocol for plugin driver errors with customizable details, and a constant defining maximum row limits for plugin operations.

Changes

Cohort / File(s) Summary
TableProPluginKit Core Utilities
Plugins/TableProPluginKit/PluginConcurrencySupport.swift, Plugins/TableProPluginKit/PluginDriverError.swift, Plugins/TableProPluginKit/PluginRowLimits.swift
Adds three new public APIs: two async/await wrapper functions for DispatchQueue execution with error handling, a PluginDriverError protocol with customizable error details and default implementations, and a PluginRowLimits enum with a 100,000 row default constant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰✨ New tools for plugin creators to explore,
Concurrency helpers, errors handled with care,
Limits set wisely at a hundred-thousand more,
The kit grows stronger, ready to share! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add shared PluginKit types' accurately and concisely describes the main change: adding three new shared types to the PluginKit framework.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/plugin-kit-shared-types

Comment @coderabbitai help to get the list of available commands and usage tips.

@datlechin datlechin merged commit 37b5cd8 into main Mar 10, 2026
2 of 3 checks passed
@datlechin datlechin deleted the feat/plugin-kit-shared-types branch March 10, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant