-
-
Notifications
You must be signed in to change notification settings - Fork 109
feat: show plugin download counts from GitHub Releases API #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
TablePro/Core/Plugins/Registry/DownloadCountService.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| // | ||
| // DownloadCountService.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
| import os | ||
|
|
||
| @MainActor @Observable | ||
| final class DownloadCountService { | ||
| static let shared = DownloadCountService() | ||
|
|
||
| private var counts: [String: Int] = [:] | ||
| private static let logger = Logger(subsystem: "com.TablePro", category: "DownloadCountService") | ||
|
|
||
| private static let cacheKey = "downloadCountsCache" | ||
| private static let cacheDateKey = "downloadCountsCacheDate" | ||
| private static let cacheTTL: TimeInterval = 3_600 // 1 hour | ||
|
|
||
| // swiftlint:disable:next force_unwrapping | ||
| private static let releasesURL = URL(string: "https://api.github.com/repos/datlechin/TablePro/releases?per_page=100")! | ||
|
|
||
| private let session: URLSession | ||
|
|
||
| private init() { | ||
| let config = URLSessionConfiguration.default | ||
| config.timeoutIntervalForRequest = 15 | ||
| config.timeoutIntervalForResource = 30 | ||
| self.session = URLSession(configuration: config) | ||
|
|
||
| loadCache() | ||
| } | ||
|
|
||
| // MARK: - Public | ||
|
|
||
| func downloadCount(for pluginId: String) -> Int? { | ||
| counts[pluginId] | ||
| } | ||
|
|
||
| func fetchCounts(for manifest: RegistryManifest?) async { | ||
| guard let manifest else { return } | ||
|
|
||
| if isCacheValid() { | ||
| Self.logger.debug("Using cached download counts") | ||
| return | ||
| } | ||
|
|
||
| do { | ||
| let releases = try await fetchReleases() | ||
| let pluginReleases = releases.filter { $0.tagName.hasPrefix("plugin-") } | ||
| let urlToPluginId = buildURLMap(from: manifest) | ||
|
|
||
| var totals: [String: Int] = [:] | ||
| for release in pluginReleases { | ||
| for asset in release.assets { | ||
| if let pluginId = urlToPluginId[asset.browserDownloadUrl] { | ||
| totals[pluginId, default: 0] += asset.downloadCount | ||
| } | ||
| } | ||
| } | ||
|
|
||
| counts = totals | ||
| saveCache(totals) | ||
| Self.logger.info("Fetched download counts for \(totals.count) plugin(s)") | ||
| } catch { | ||
| Self.logger.error("Failed to fetch download counts: \(error.localizedDescription)") | ||
| } | ||
| } | ||
|
|
||
| // MARK: - GitHub API | ||
|
|
||
| private func fetchReleases() async throws -> [GitHubRelease] { | ||
| var request = URLRequest(url: Self.releasesURL) | ||
| request.setValue("application/vnd.github+json", forHTTPHeaderField: "Accept") | ||
|
|
||
| let (data, response) = try await session.data(for: request) | ||
|
|
||
| guard let httpResponse = response as? HTTPURLResponse, | ||
| (200...299).contains(httpResponse.statusCode) else { | ||
| throw URLError(.badServerResponse) | ||
| } | ||
|
|
||
| let decoder = JSONDecoder() | ||
| decoder.keyDecodingStrategy = .convertFromSnakeCase | ||
| return try decoder.decode([GitHubRelease].self, from: data) | ||
| } | ||
|
|
||
| // MARK: - URL Mapping | ||
|
|
||
| private func buildURLMap(from manifest: RegistryManifest) -> [String: String] { | ||
| var map: [String: String] = [:] | ||
| for plugin in manifest.plugins { | ||
| if let binaries = plugin.binaries { | ||
| for binary in binaries { | ||
| map[binary.downloadURL] = plugin.id | ||
| } | ||
| } | ||
| if let url = plugin.downloadURL { | ||
| map[url] = plugin.id | ||
| } | ||
| } | ||
| return map | ||
| } | ||
|
|
||
| // MARK: - Cache | ||
|
|
||
| private func isCacheValid() -> Bool { | ||
| guard let cacheDate = UserDefaults.standard.object(forKey: Self.cacheDateKey) as? Date else { | ||
| return false | ||
| } | ||
| return Date().timeIntervalSince(cacheDate) < Self.cacheTTL | ||
| } | ||
|
|
||
| private func loadCache() { | ||
| guard isCacheValid(), | ||
| let data = UserDefaults.standard.data(forKey: Self.cacheKey), | ||
| let cached = try? JSONDecoder().decode([String: Int].self, from: data) else { | ||
| counts = [:] | ||
| return | ||
| } | ||
| counts = cached | ||
| } | ||
|
|
||
| private func saveCache(_ totals: [String: Int]) { | ||
| if let data = try? JSONEncoder().encode(totals) { | ||
| UserDefaults.standard.set(data, forKey: Self.cacheKey) | ||
| UserDefaults.standard.set(Date(), forKey: Self.cacheDateKey) | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - GitHub API Models | ||
|
|
||
| private struct GitHubRelease: Decodable { | ||
| let tagName: String | ||
| let assets: [GitHubAsset] | ||
| } | ||
|
|
||
| private struct GitHubAsset: Decodable { | ||
| let name: String | ||
| let downloadCount: Int | ||
| let browserDownloadUrl: String | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.