fix: switch keychain to Data Protection to eliminate auth prompts#328
Merged
fix: switch keychain to Data Protection to eliminate auth prompts#328
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeychainHelperusing the Data Protection keychain (kSecUseDataProtectionKeychain: true) per Apple TN3137, eliminating per-item ACL prompts that appeared on every table openkSecAttrAccessibletoAfterFirstUnlock(wasWhenUnlockedThisDeviceOnly), restoring background reconnection while screen is lockedConnectionStorage,AIKeyStorage, andLicenseStorageto delegate all keychain operations toKeychainHelperCloses #326
Test plan
AfterFirstUnlock)KeychainHelperTestsandKeychainAccessControlTestsSummary by CodeRabbit
New Features
Bug Fixes
Tests
Chores