Skip to content

fix: welcome window UX polish #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 2 commits into from
Mar 24, 2026
Merged

fix: welcome window UX polish #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1d0c8
fix: welcome window UX polish — Escape, focus, Cmd+A, Return hint, me…
datlechin Mar 24, 2026
5619281
fix: restore checkmark indicator for current group in Move to Group menu
datlechin Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions TablePro/Views/Connection/WelcomeWindowView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ struct WelcomeWindowView: View {
.frame(minWidth: 650, minHeight: 400)
.onAppear {
loadConnections()
focus = .search
}
.confirmationDialog(
connectionsToDelete.count == 1
Expand Down Expand Up @@ -241,6 +242,7 @@ struct WelcomeWindowView: View {
// Footer hints
HStack(spacing: 16) {
SyncStatusIndicator()
KeyboardHint(keys: "↵", label: "Connect")
KeyboardHint(keys: "⌘N", label: "New")
KeyboardHint(keys: "⌘,", label: "Settings")
}
Expand Down Expand Up @@ -302,6 +304,13 @@ struct WelcomeWindowView: View {
connectSelectedConnections()
return .handled
}
.onKeyPress(.escape) {
if !searchText.isEmpty {
searchText = ""
}
focus = .connectionList
return .handled
}
.onKeyPress(characters: .init(charactersIn: "\u{7F}\u{08}"), phases: .down) { keyPress in
guard keyPress.modifiers.contains(.command) else { return .ignored }
let toDelete = selectedConnections
Expand Down Expand Up @@ -418,6 +427,17 @@ struct WelcomeWindowView: View {
showDeleteConfirmation = true
return .handled
}
.onKeyPress(characters: .init(charactersIn: "a"), phases: .down) { keyPress in
guard keyPress.modifiers.contains(.command) else { return .ignored }
selectedConnectionIds = Set(flatVisibleConnections.map(\.id))
return .handled
}
.onKeyPress(.escape) {
if !selectedConnectionIds.isEmpty {
selectedConnectionIds = []
}
return .handled
}
.onKeyPress(characters: .init(charactersIn: "jn"), phases: [.down, .repeat]) { keyPress in
guard keyPress.modifiers.contains(.control) else { return .ignored }
moveToNextConnection()
Expand Down Expand Up @@ -663,9 +683,8 @@ struct WelcomeWindowView: View {
} label: {
HStack {
if !group.color.isDefault {
Circle()
.fill(group.color.color)
.frame(width: 8, height: 8)
Image(systemName: "circle.fill")
.foregroundStyle(group.color.color)
}
Text(group.name)
if currentGroupId == group.id {
Expand Down
Loading