fix: prevent connection data loss on normal app quit#453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #452 — saved connections disappear after normal app quit (Cmd+Q) but persist after force quit.
WelcomeWindowView.loadConnections()overwrites UserDefaults with an empty array whenstorage.loadConnections()returns empty during SwiftUI scene teardown on quit. SinceDatabaseConnection.sampleConnectionswas[], this destructively erased valid saved data.loadConnections()now simply reads from storage without writing backUserDefaults.standard.synchronize()inapplicationWillTerminateas a defensive flushsampleConnections(empty array indexed at[0]in previews) with a properDatabaseConnection.previewstaticTest plan