fix: deep link cold launch missing toolbar and duplicate windows#467
Merged
fix: deep link cold launch missing toolbar and duplicate windows#467
Conversation
…n leak - Connect-before-window for deep links to prevent SwiftUI toolbar drop bug - Deduplicate connections by param key (catches transient UUIDs and cross-path races) - Use file path dedup for SQLite/DuckDB/generic file handlers - Balance endFileOpenSuppression at batch level in handleOpenURLs - Hide SwiftUI state-restored orphan windows via orderOut in windowDidBecomeKey - Set pendingConnectionId at all openWindow(id:"main") call sites - Set isRestorable=false on main windows to reduce restoration attempts - Update window title on first session connect for cold-launch deep links
…disDatabase in paramKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #465
connectToSessionbeforeopenNewConnectionWindowso the session is already inactiveSessionswhenContentView.initruns. This avoids a SwiftUI bug where toolbar items are dropped when theNavigationSplitViewdetail transitions from "Connecting..." toMainContentView.connectingURLConnectionIdsguard set to prevent duplicate windows when the same deep link URL is opened twice rapidly (or re-processed from the cold-start queue).windowTitleinhandleConnectionStatusChangewhen the session first connects, fixing the stale "SQL Query" fallback title on cold launch.Test plan
open "mysql://root@localhost/db?name=Test" -a TablePro— toolbar, title, and sidebar should all render correctlyopencommand twice quickly — should only create one connection windowopen test.sqlite -a TableProon cold launch