Skip to content

fix: XLSX export producing corrupted files in Excel #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 2 commits into from
Mar 26, 2026
Merged

fix: XLSX export producing corrupted files in Excel #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebe6db2
fix: XLSX export producing corrupted files in Excel (#464)
datlechin Mar 26, 2026
a6adafb
Merge branch 'main' into fix/xlsx-export-corrupted-464
datlechin Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- XLSX export producing corrupted files that Excel cannot open (#464)
- Deep link cold launch missing toolbar and duplicate windows (#465)

### Added
Expand Down
18 changes: 13 additions & 5 deletions Plugins/XLSXExportPlugin/XLSXWriter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ final class XLSXWriter {
d.appendUTF8("<cellXfs count=\"2\">")
d.appendUTF8("<xf numFmtId=\"0\" fontId=\"0\" fillId=\"0\" borderId=\"0\" xfId=\"0\"/>")
d.appendUTF8("<xf numFmtId=\"0\" fontId=\"1\" fillId=\"0\" borderId=\"0\" xfId=\"0\" applyFont=\"1\"/>")
d.appendUTF8("</cellXfs></styleSheet>")
d.appendUTF8("</cellXfs>")
d.appendUTF8("<cellStyles count=\"1\"><cellStyle name=\"Normal\" xfId=\"0\" builtinId=\"0\"/></cellStyles>")
d.appendUTF8("</styleSheet>")
return d
}

Expand Down Expand Up @@ -309,7 +311,9 @@ private extension Data {
} ?? self.append(contentsOf: string.utf8)
}

/// Append XML-escaped text directly to Data without creating intermediate Strings
/// Append XML-escaped text directly to Data without creating intermediate Strings.
/// Strips XML 1.0 illegal control characters (0x00–0x08, 0x0B, 0x0C, 0x0E–0x1F)
/// that can appear in binary/hex database columns and would produce malformed XML.
mutating func appendXMLEscaped(_ text: String) {
for byte in text.utf8 {
switch byte {
Expand All @@ -323,6 +327,10 @@ private extension Data {
append(contentsOf: [0x26, 0x71, 0x75, 0x6F, 0x74, 0x3B]) // &quot;
case 0x27: // '
append(contentsOf: [0x26, 0x61, 0x70, 0x6F, 0x73, 0x3B]) // &apos;
case 0x09, 0x0A, 0x0D: // Tab, LF, CR — allowed in XML 1.0
append(byte)
case 0x00...0x08, 0x0B, 0x0C, 0x0E...0x1F: // Illegal XML 1.0 control chars
break // Strip silently
default:
append(byte)
}
Expand Down Expand Up @@ -360,7 +368,7 @@ private enum ZipBuilder {

// Local file header
output.append(contentsOf: [0x50, 0x4B, 0x03, 0x04]) // Signature
output.appendUInt16(20) // Version needed
output.appendUInt16(10) // Version needed (1.0 for store)
output.appendUInt16(0) // Flags
output.appendUInt16(0) // Compression: stored
output.appendUInt16(0) // Mod time
Expand All @@ -375,8 +383,8 @@ private enum ZipBuilder {

// Central directory entry
centralDirectory.append(contentsOf: [0x50, 0x4B, 0x01, 0x02])
centralDirectory.appendUInt16(20)
centralDirectory.appendUInt16(20)
centralDirectory.appendUInt16(20) // Version made by (2.0)
centralDirectory.appendUInt16(10) // Version needed (1.0 for store)
centralDirectory.appendUInt16(0)
centralDirectory.appendUInt16(0)
centralDirectory.appendUInt16(0)
Expand Down
Loading