Skip to content

349. Intersection of Two Arrays#13

Open
TakayaShirai wants to merge 1 commit intomainfrom
349_intersection_of_two_arrays
Open

349. Intersection of Two Arrays#13
TakayaShirai wants to merge 1 commit intomainfrom
349_intersection_of_two_arrays

Conversation

@TakayaShirai
Copy link
Copy Markdown
Owner

Comment on lines +125 to +129
if (nums1.length > nums2.length) {
var tmp = nums1;
nums1 = nums2;
nums2 = tmp;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
重箱の隅をつつくようなコメントで恐縮ですが(他は特にコメントしようもないほど充実していました)…

  • スワップするという本質的でない操作の割に行数を占めているので、括り出したい
  • そもそも「短い方を nums1 にする」なら、その意図まで命名に反映してはどうか

ということで、

Suggested change
if (nums1.length > nums2.length) {
var tmp = nums1;
nums1 = nums2;
nums2 = tmp;
}
final (smaller, larger) = orderByLength(nums1, nums2);

とかはどうでしょうか。

  (List<int>, List<int>) orderByLength(List<int> a, List<int> b) {
    return (a.length < b.length) ? (a, b) : (b, a);
  }

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューありがとうございます!

確かに非対称的な変数に対して、nums1, nums2 などの対称を想起しそうな命名はあまり良くなかったです。括り出す方針も賛成です!

@TakayaShirai TakayaShirai self-assigned this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants