Open
Conversation
mamo3gr
reviewed
Jan 12, 2026
Comment on lines
+84
to
+85
| var cumulativeSum = 0; | ||
| var sumToCount = <int, int>{cumulativeSum: 1}; |
There was a problem hiding this comment.
これ、とても良いと思いました。
「いまの累積和は0です」「その累積和を1回見ました」という意図が伝わってきました。
mamo3gr
reviewed
Jan 12, 2026
| for (var num in nums) { | ||
| cumulativeSum += num; | ||
|
|
||
| final target = cumulativeSum - k; |
There was a problem hiding this comment.
k も問題で与えられた target なわけで、ここで改めて出てきた target とは?とわずかに混乱しました。個人的には、どこかのPRで見た complement が結構しっくり来ました。ご参考まで
Owner
Author
There was a problem hiding this comment.
いつもレビューありがとうございます!
確かに target だと何も具体的な役割を伝えられていないですね…。complementの方が私もしっくりきます、ありがとうございます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題:https://leetcode.com/problems/subarray-sum-equals-k/description/
次に解く問題:https://leetcode.com/problems/number-of-islands/description/