Open
Conversation
5ky7
reviewed
Mar 3, 2026
| return 0; | ||
| } | ||
| if (position == 0) { | ||
| maxMoneyAt[position] = nums[0]; |
There was a problem hiding this comment.
nit: positionか0かに統一すると良いと思います．
Suggested change
| maxMoneyAt[position] = nums[0]; | |
| maxMoneyAt[0] = nums[0]; |
| } | ||
| if (position == 0) { | ||
| maxMoneyAt[position] = nums[0]; | ||
| return nums[0]; |
There was a problem hiding this comment.
これもnitpickですが，他のパターンは全てreturn maxMoneyAt[position]なので，統一したくなる気持ちになります．
Suggested change
| return nums[0]; | |
| return maxMoneyAt[0]; |
| // - **できるだけ高レベルな抽象化を使う**: 自分でロックを細かく制御するよりも、Actor モデルやチャネルベースの通信（Goのgoroutine + channel など）の方がバグりにくい | ||
|
|
||
| // 二変数の方法でも書いておく | ||
| // もう少しいい命名がある気がするが、思いつかなかった。 |
There was a problem hiding this comment.
どこをcurrentとみるのか（2変数をcurrentとpreviousとみるか，previousとpreviousのpreviousとみるか）は人によると思いますが，この命名で問題なく読めました．
There was a problem hiding this comment.
[fyi]
個人的には RobLast, SkipLast がしっくりきました。
|
全体的に読みやすかったです 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解いた問題：https://leetcode.com/problems/house-robber/description/
次に解く問題：https://leetcode.com/problems/house-robber-ii/description/