Skip to content

Conversation

@KyleAMathews
Copy link
Collaborator

Add build:minified scripts that enable minification during builds, and configure the compressed-size-action to use these scripts.

This ensures that bundle size measurements in PRs reflect actual code changes rather than being inflated by comments and whitespace, while keeping the published packages readable and unminified.

Changes:

  • Add build:minified script to root package.json
  • Add build:minified scripts to @tanstack/db and @tanstack/react-db
  • Configure compressed-size-action to use build:minified script

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Add build:minified scripts that enable minification during builds,
and configure the compressed-size-action to use these scripts.

This ensures that bundle size measurements in PRs reflect actual
code changes rather than being inflated by comments and whitespace,
while keeping the published packages readable and unminified.

Changes:
- Add build:minified script to root package.json
- Add build:minified scripts to @tanstack/db and @tanstack/react-db
- Configure compressed-size-action to use build:minified script
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

⚠️ No Changeset found

Latest commit: 6bbfc52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@736

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@736

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@736

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@736

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@736

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@736

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@736

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@736

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@736

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@736

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@736

commit: 6bbfc52

@samwillis
Copy link
Collaborator

@KyleAMathews the Preview CI task is failing with this error (and it doesn't seem to be a flake):

  /home/runner/setup-pnpm/node_modules/.bin/pnpm run build:minified
   ERR_PNPM_NO_SCRIPT  Missing script: build:minified
  
  Command "build:minified" not found.
  Error: The process '/home/runner/setup-pnpm/node_modules/.bin/pnpm' failed with exit code 1

@KyleAMathews
Copy link
Collaborator Author

@samwillis it's trying to run the script on main where it doesn't exist yet — so once we merge this in it should work.

@KyleAMathews KyleAMathews merged commit d2b569c into main Oct 31, 2025
10 of 14 checks passed
@KyleAMathews KyleAMathews deleted the claude/investigate-size-change-action-011CUdrAxL5rape37MZjt7mz branch October 31, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants