-
Notifications
You must be signed in to change notification settings - Fork 4
Clap-113 요청 생성 및 수정에 첨부파일 업로드 로직 추가 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoseong-Choi
approved these changes
Jan 26, 2025
hyoseong-Choi
approved these changes
Jan 26, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@value 쓰는 부분이 test의 yml파일에 없어서 Placeholder에러가 생기는거 같은데 이것만 수정해주시면 좋을 것 같습니다
parkjaehak
approved these changes
Jan 26, 2025
parkjaehak
requested changes
Jan 26, 2025
...main/java/clap/server/adapter/outbound/persistense/repository/task/AttachmentRepository.java
Outdated
Show resolved
Hide resolved
<footer> - 관련: #76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
첨부파일 업로드 방식 변경 : presigned url -> multi part
S3 업로드 서비스 구현
요청 usecase 리팩토링
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
@hyoseong-Choi s3 설정에 관한 환경 변수를 vm에 등록해놓은 상태입니다. 참고 부탁드립니다.
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #76