-
Notifications
You must be signed in to change notification settings - Fork 4
CLAP-150 시스템과 외부 푸시 알림 기능 구현 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joowojr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outbound/persistence는 영속성을 가진 데이터 db와 상호작용합니다.
웹훅 및 이메일 전송은 외부 시스템과의 상호작용이기 때분에 outbound/api 디렉토리로 이동 부탁드립니다!
persistence adapter는 필요하지 않고 외부 api client가 application/port의 구현체가 되면 될 것 같습니다.
따라서 아래와 같은 구조가 될 수 있겠네요.
├── adapter
│ ├── in
│ │ └── web
│ │ └── ...Controller.java
│ └── out
│ ├── api
│ ├── GoogleMailClient.java
│ ├── AgitClient.java
│ └── KakaoWorkClient.java
├── application
│ └── port
│ └── outbound
│ └── SendEmailPort.java
|
@joowojr 수정 완료하였습니다! 확인 부탁드립니다! |
joowojr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다. 리뷰확인 부탁드립니다:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request dto도 oubound/api/dto로 이동 해야할거같아요!
| @RequiredArgsConstructor | ||
| public class KakaoWorkClient implements SendKaKaoWorkPort { | ||
|
|
||
| private static final String KAKAOWORK_URL = "https://api.kakaowork.com/v1/messages.send_by_email"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
중요한 정보기 때문에 환경변수화 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sse 관련은 외부로 나가는 기술에 의존하기 때문에 outbound/infrastructure/sse로 이동하면 좋을것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 클래스의 역할이 무엇일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
따로 api가 있는 이유가 무엇인지 궁금합니다!
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #{이슈 번호}