Add ability to import OSM XML directly #15
Conversation
Signed-off-by: Cy Rossignol <cy@rossignols.me>
| && datasetFile.value instanceof File | ||
| && datasetFile.value.name.endsWith('.zip') | ||
| && (datasetFile.value.name.endsWith('.zip') | ||
| || datasetFile.value.name.endsWith('.xml')) |
There was a problem hiding this comment.
The .osm extension is a little messy—OSM publishes the official planet file with the .osm extension, but other tools like JOSM may use the extension for both OSM XML and for changeset diffs (instead of .osc). We would need to peek the file to determine how to process it.
Though, I suppose the same issue exists with the .xml extension. Maybe we should shelve this until we have time to write out the validation logic.
|
|
||
| async _run(data: Blob, workspace): Promise<number> { | ||
| if (workspace.type === 'osw') { | ||
| if (workspace.type === 'osw' && !isMimeXml(data.type)) { |
There was a problem hiding this comment.
Should we add a check for the mime type of a .zip file and display an error if the file is neither .zip or .xml vs. assuming anything not .xml is .zip?
There was a problem hiding this comment.
Yeah, that makes sense. Originally, this was "feed anything through to the converter, and let it complain if it doesn't support it", but it looks like the converter API's error messages are not helpful at all.
There was a problem hiding this comment.
LMK if you wanna connect on wrapping this up!
This adds the ability to select an OSM XML file for import with the "Create Workspace from File" workflow. I used this while testing the output of the new SQL-based converter. It seems useful enough to keep around.