Skip to content

[Refactor]: CategoryServiceImplTest 단위 테스트 -> 통합 테스트로 변경 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sese2204 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Refactor]: CategoryServiceImplTest 단위 테스트 -> 통합 테스트로 변경 #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 28 additions & 79 deletions src/test/java/com/pickyfy/pickyfy/service/CategoryServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.verify;

import com.pickyfy.pickyfy.domain.Category;
import com.pickyfy.pickyfy.domain.CategoryType;
Expand All @@ -13,59 +10,27 @@
import com.pickyfy.pickyfy.web.dto.request.CategoryTypeRequest;
import com.pickyfy.pickyfy.web.dto.response.CategoryResponse;
import jakarta.persistence.EntityNotFoundException;
import java.lang.reflect.Field;
import java.util.List;
import java.util.Optional;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.transaction.annotation.Transactional;

import java.util.List;

@ExtendWith(MockitoExtension.class)
@SpringBootTest
@Transactional
class CategoryServiceImplTest {

@Mock
@Autowired
private CategoryRepository categoryRepository;

@InjectMocks
private CategoryServiceImpl categoryService;

private Category category;

@BeforeEach
void setUp() throws NoSuchFieldException, IllegalAccessException {
category = Category.builder()
.type(CategoryType.CAFE_BAKERY)
.build();

// Reflection으로 id 설정
Field idField = Category.class.getDeclaredField("id");
idField.setAccessible(true);
idField.set(category, 1L);
}

@Test
void createCategory_Success() {
// Given
CategoryTypeRequest request = new CategoryTypeRequest(CategoryType.CAFE_BAKERY);
given(categoryRepository.existsByType(request.categoryType())).willReturn(false);
given(categoryRepository.save(any(Category.class))).willReturn(category);

// When
Long categoryId = categoryService.createCategory(request);

// Then
assertThat(categoryId).isEqualTo(1L);
verify(categoryRepository).save(any(Category.class));
}
@Autowired
private CategoryService categoryService;

@Test
void createCategory_DuplicateType_ThrowsException() {
// Given
CategoryTypeRequest request = new CategoryTypeRequest(CategoryType.CAFE_BAKERY);
given(categoryRepository.existsByType(request.categoryType())).willReturn(true);

// When/Then
assertThatThrownBy(() -> categoryService.createCategory(request))
Expand All @@ -74,60 +39,42 @@ void createCategory_DuplicateType_ThrowsException() {

@Test
void getCategory_Success() {
// Given
given(categoryRepository.findById(1L)).willReturn(Optional.of(category));

// When
CategoryResponse response = categoryService.getCategory(1L);

// Then
assertThat(response.id()).isEqualTo(1L);
assertThat(response.name()).isEqualTo(CategoryType.CAFE_BAKERY.getDisplayName());
assertThat(response.name()).isEqualTo(CategoryType.ALL.getDisplayName());
}

@Test
void getCategory_NotFound_ThrowsException() {
given(categoryRepository.findById(1L)).willReturn(Optional.empty());
// Given
Long nonExistentId = 999L;

assertThatThrownBy(() -> categoryService.getCategory(1L))
// When/Then
assertThatThrownBy(() -> categoryService.getCategory(nonExistentId))
.isInstanceOf(EntityNotFoundException.class);
}

@Test
void getAllCategories_Success() {
// Given
List<Category> categories = List.of(category);
given(categoryRepository.findAll()).willReturn(categories);

// When
List<CategoryResponse> responses = categoryService.getAllCategories();

// Then
assertThat(responses).hasSize(1);
assertThat(responses).hasSize(7);
assertThat(responses.getFirst().id()).isEqualTo(1L);
assertThat(responses.getFirst().name()).isEqualTo(CategoryType.CAFE_BAKERY.getDisplayName());
}

@Test
void updateCategory_Success() {
// Given
CategoryTypeRequest request = new CategoryTypeRequest(CategoryType.RESTAURANT);
given(categoryRepository.findById(1L)).willReturn(Optional.of(category));
given(categoryRepository.existsByType(request.categoryType())).willReturn(false);

// When
categoryService.updateCategory(1L, request);

// Then
assertThat(category.getType()).isEqualTo(CategoryType.RESTAURANT);
}

@Test
void updateCategory_DuplicateType_ThrowsException() {
// Given
Category anotherCategory = Category.builder()
.type(CategoryType.RESTAURANT)
.build();
categoryRepository.save(anotherCategory);

CategoryTypeRequest request = new CategoryTypeRequest(CategoryType.RESTAURANT);
given(categoryRepository.findById(1L)).willReturn(Optional.of(category));
given(categoryRepository.existsByType(request.categoryType())).willReturn(true);

// When/Then
assertThatThrownBy(() -> categoryService.updateCategory(1L, request))
Expand All @@ -136,18 +83,20 @@ void updateCategory_DuplicateType_ThrowsException() {

@Test
void deleteCategory_Success() {
given(categoryRepository.findById(1L)).willReturn(Optional.of(category));

// When
categoryService.deleteCategory(1L);

verify(categoryRepository).delete(category);
// Then
assertThat(categoryRepository.findById(1L)).isEmpty();
}

@Test
void deleteCategory_NotFound_ThrowsException() {
given(categoryRepository.findById(1L)).willReturn(Optional.empty());
// Given
Long nonExistentId = 999L;

assertThatThrownBy(() -> categoryService.deleteCategory(1L))
// When/Then
assertThatThrownBy(() -> categoryService.deleteCategory(nonExistentId))
.isInstanceOf(EntityNotFoundException.class);
}
}