Skip to content

Fix(tooltip): added container prop in tooltip for placement# 46923553 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malmakova-na wants to merge 5 commits into
base: TechAudit-5.4.1
Choose a base branch
from
Open

Fix(tooltip): added container prop in tooltip for placement# 46923553 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3f4740
fix(tooltip): added container prop of tooltip component for placement
malmakova-na Mar 10, 2025
583be6b
release
malmakova-na Mar 10, 2025
abe05b9
fix indent
malmakova-na Mar 10, 2025
43bd73b
used ?? for container variable in tooltipview
malmakova-na Mar 20, 2025
48fbeac
fix indent
malmakova-na Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dist/echarts.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56061,7 +56061,8 @@

var tooltipModel = ecModel.getComponent('tooltip');
var renderMode = this._renderMode = getTooltipRenderMode(tooltipModel.get('renderMode'));
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(api.getDom(), api, {
var container = tooltipModel.option.container ? tooltipModel.option.container : api.getDom();
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(container, api, {
appendToBody: tooltipModel.get('appendToBody', true)
});
};
Expand Down
2 changes: 1 addition & 1 deletion dist/echarts.common.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/echarts.common.min.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion dist/echarts.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83137,7 +83137,8 @@ function (_super) {

var tooltipModel = ecModel.getComponent('tooltip');
var renderMode = this._renderMode = getTooltipRenderMode(tooltipModel.get('renderMode'));
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(api.getDom(), api, {
var container = tooltipModel.option.container ? tooltipModel.option.container : api.getDom();
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(container, api, {
appendToBody: tooltipModel.get('appendToBody', true)
});
};
Expand Down
2 changes: 1 addition & 1 deletion dist/echarts.esm.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/echarts.esm.min.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion dist/echarts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83143,7 +83143,8 @@

var tooltipModel = ecModel.getComponent('tooltip');
var renderMode = this._renderMode = getTooltipRenderMode(tooltipModel.get('renderMode'));
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(api.getDom(), api, {
var container = tooltipModel.option.container ? tooltipModel.option.container : api.getDom();
this._tooltipContent = renderMode === 'richText' ? new TooltipRichContent(api) : new TooltipHTMLContent(container, api, {
appendToBody: tooltipModel.get('appendToBody', true)
});
};
Expand Down
2 changes: 1 addition & 1 deletion dist/echarts.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/echarts.min.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions src/component/tooltip/TooltipModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ export interface TooltipOption extends CommonTooltipOption<TopLevelFormatterPara
className?: string

order?: TooltipOrderMode

/** specified container ref where tooltip will be placed */
container?: HTMLElement
}

class TooltipModel extends ComponentModel<TooltipOption> {
Expand Down
3 changes: 2 additions & 1 deletion src/component/tooltip/TooltipView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,11 @@ class TooltipView extends ComponentView {

const tooltipModel = ecModel.getComponent('tooltip') as TooltipModel;
const renderMode = this._renderMode = getTooltipRenderMode(tooltipModel.get('renderMode'));
const container = tooltipModel.option.container ?? api.getDom();

this._tooltipContent = renderMode === 'richText'
? new TooltipRichContent(api)
: new TooltipHTMLContent(api.getDom(), api, {
: new TooltipHTMLContent(container, api, {
appendToBody: tooltipModel.get('appendToBody', true)
});
}
Expand Down