Clean up shader references #830
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FYI, Shader Program Keys still works; but it isn't the same; and they made it harder to reference / use them. I have them working, personally. ( Example: https://github.com/sakura-ryoko/malilib/blob/d030f3a6daf675a7bd606a37f2c5d0dcb68abccf/src/main/java/fi/dy/masa/malilib/render/RenderContext.java#L204 ) But either way, this is still important work. I nearly have PAPI ready also, just waiting on PRE. |
Closed
Contributor
|
Some of this was merged in #861. Do you want to update the rest to merge into 1.21.11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces some minor refactors to rendering that remove all references to
RenderSystemandShaderProgramKeys, the latter of which is removed in Minecraft snapshot 25w07a. This change can also be backported to other version branches.