fix: minor bugs and UX polish batch#116
Merged
TerrifiedBug merged 4 commits intomainfrom Mar 28, 2026
Merged
Conversation
Add selectedTeamId guard before the error check so the page shows loading skeletons instead of a failed query when the Zustand store hasn't hydrated yet. Also surface the actual TRPC error message.
The Switch looked like an enable/disable toggle rather than a choice between Local and S3 storage. The segmented control makes the two options visually explicit.
Show copy-able Quick Start snippets for both the install.sh one-liner and docker run command when an enrollment token exists. Server URL and token are pre-filled dynamically. Also updates the public docs with both enrollment methods.
Contributor
Greptile SummaryThis PR delivers five targeted bug fixes and UX improvements with no functional regressions. The changes are focused and well-scoped:
Confidence Score: 5/5All five changes are correct, scoped, and safe to merge. No P0 or P1 issues found. The webhook hydration guard is correctly ordered relative to the disabled query, the SSE downgrade is appropriate, the segmented control uses type=button safely, and the Quick Start snippet copy behavior matches what is displayed. All findings are P2 at most. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WebhookEndpointsSettings renders] --> B{selectedTeamId?}
B -- No --> C[Return skeletons\nZustand not hydrated yet]
B -- Yes --> D[listQuery enabled\nfetch webhooks]
D --> E{listQuery.isError?}
E -- Yes --> F[QueryError with\nlistQuery.error.message\nor fallback string]
E -- No --> G[Render endpoint list\nor empty state]
H[Environment Detail Page] --> I{env.hasEnrollmentToken?}
I -- Yes --> J[Show Quick Start section]
J --> K{enrollmentToken state set?}
K -- Yes --> L[Snippets show actual token +\ncopy embeds real token]
K -- No --> M[Snippets show placeholder\ncopy embeds placeholder]
Reviews (1): Last reviewed commit: "feat: add Linux and Docker enrollment in..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warntoconsole.debug(fires in dev due to React Strict Mode, guard logic is correct)[ Local | S3 ]) that clearly communicates a choice between two optionsinstall.shone-liner) and Docker (docker run) to the environment detail page with pre-filled server URL and token; update public docsTest plan
/settings/webhooks— page loads without error[useSSE]warning at warn level/settings/backup— storage backend shows segmented control, selecting S3 reveals credential fields