fix: prevent horizontal scroll on expanded audit log rows#49
Merged
TerrifiedBug merged 1 commit intomainfrom Mar 7, 2026
Merged
fix: prevent horizontal scroll on expanded audit log rows#49TerrifiedBug merged 1 commit intomainfrom
TerrifiedBug merged 1 commit intomainfrom
Conversation
Wrap the audit table in overflow-x-auto, use table-fixed layout, and constrain expanded detail values with minmax(0,1fr) grid columns, break-all, and whitespace-pre-wrap on JSON blocks.
Contributor
Greptile SummaryThis PR fixes horizontal scroll on the audit log page by containing the table in an
Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["Audit Page Root div"] --> B["Filter Bar Card"]
A --> C{"Data state?"}
C -->|Loading| D["Skeleton rows"]
C -->|Empty| E["Empty state message"]
C -->|Has data| F["Fragment <>"]
F --> G["div.overflow-x-auto\n(new wrapper)"]
G --> H["Table.table-fixed.w-full"]
H --> I["TableHeader\n(8 columns)"]
H --> J["TableBody\n(allItems.map)"]
J --> K["TableRow\n(summary row)"]
K -->|isExpanded && hasDetails| L["TableRow.bg-muted/30\n(expanded detail row)"]
L --> M["TableCell colSpan=8"]
M -->|hasMetadata| N["Details grid\ngrid-cols-auto_minmax(0,1fr)\n(fixed from auto_1fr)"]
M -->|hasDiff| O["Changes grid\ngrid-cols-auto_minmax(0,1fr)\n(fixed from auto_1fr)"]
N --> P["key span.whitespace-nowrap"]
N --> Q{value type?}
Q -->|object| R["pre.whitespace-pre-wrap\n.break-all.overflow-hidden"]
Q -->|primitive| S["span.break-all"]
F --> T["Load more Button\n(outside overflow-x-auto)"]
Last reviewed commit: f503497 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow-x-autocontainer withtable-fixedlayoutauto_1frtoauto_minmax(0,1fr)so values respect container boundsbreak-allandwhitespace-pre-wrapon long metadata/diff values to prevent content from pushing the page widerTest plan