Skip to content

fix: improve SSO-only login page layout#58

Merged
TerrifiedBug merged 1 commit intomainfrom
fix/sso-only-login-layout
Mar 7, 2026
Merged

fix: improve SSO-only login page layout#58
TerrifiedBug merged 1 commit intomainfrom
fix/sso-only-login-layout

Conversation

@TerrifiedBug
Copy link
Copy Markdown
Owner

Summary

  • Remove empty CardContent/CardFooter gap when local authentication is disabled, eliminating the large dead space in the SSO-only login card
  • Center text and add a shield icon badge as a visual anchor
  • Consolidate the SSO button into CardContent (removing separate CardFooter) for a compact layout

Test plan

  • Set LOCAL_LOGIN_DISABLED=true and OIDC_ENABLED=true — verify the login card is compact with centered text and shield icon
  • Verify the SSO button still works correctly
  • Set LOCAL_LOGIN_DISABLED=false — verify the standard login form is unchanged
  • Trigger an SSO error and confirm the error message renders centered within the card

Remove empty CardContent/CardFooter gap when local auth is disabled.
Center text, add shield icon badge, and consolidate button into
CardContent for a compact, intentional layout.
@github-actions github-actions bot added the fix label Mar 7, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR is a focused UI polish for the SSO-only login page (when local auth is disabled and OIDC is enabled). It eliminates the dead space that previously existed between CardContent and CardFooter by consolidating the SSO button into CardContent and removing the separate CardFooter. A centered shield icon badge and centered text are added as visual anchors. The standard login form path is completely untouched.

  • Moves <Button> from <CardFooter> into <CardContent> to eliminate the layout gap in the SSO-only branch
  • Adds a Shield icon badge in CardHeader as a visual anchor (centered)
  • Centers CardHeader text and the error message in the SSO-only branch
  • Adds pt-0 to CardContent and pb-4 to CardHeader for compact spacing
  • No functional, logic, or security changes — the standard login form, TOTP flow, and SSO callback handling are all unaffected

Confidence Score: 5/5

  • This PR is safe to merge — changes are purely cosmetic and scoped to a single conditional UI branch.
  • The diff touches only Tailwind class strings and JSX structure within the SSO-only rendering branch. No logic, state, authentication flow, or API calls were modified. The standard login form, TOTP handling, and SSO callback are all untouched. No new imports were added and no existing ones became unused.
  • No files require special attention.

Last reviewed commit: c43ab60

@TerrifiedBug TerrifiedBug merged commit 57bf321 into main Mar 7, 2026
12 checks passed
@TerrifiedBug TerrifiedBug deleted the fix/sso-only-login-layout branch March 7, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant