Skip to content

fix: enrichment host field, dashboard overlap, and settings polish#63

Merged
TerrifiedBug merged 4 commits intomainfrom
fix/enrichment-host-and-ui-polish
Mar 7, 2026
Merged

fix: enrichment host field, dashboard overlap, and settings polish#63
TerrifiedBug merged 4 commits intomainfrom
fix/enrichment-host-and-ui-polish

Conversation

@TerrifiedBug
Copy link
Copy Markdown
Owner

Summary

  • Add .vectorflow.host = get_hostname!() to enrichment metadata VRL
  • Fix dashboard stat cards overlapping the view tab bar (remove -mb-4)
  • Remove blue dot indicator from pipeline settings gear icon
  • Clean up pipeline settings popover layout (inline toggle, aligned collapsibles)

Test plan

  • Deploy pipeline with enrichment enabled → verify YAML includes .vectorflow.host = get_hostname!()
  • Dashboard page → stat cards no longer overlap the view tabs
  • Pipeline editor → settings gear has no blue dot
  • Pipeline editor → open settings popover → toggle and description are aligned, collapsibles have consistent styling

@github-actions github-actions bot added the fix label Mar 7, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR delivers four targeted fixes across the pipeline editor and dashboard: injecting .vectorflow.host = get_hostname!() into the enrichment VRL, removing a negative margin that caused stat cards to visually overlap the dashboard tab bar, removing the blue dot indicator from the settings gear icon, and cleaning up the pipeline settings popover layout for better alignment. The changes are small, self-consistent, and low-risk.

Key changes:

  • yaml-generator.ts: Adds .vectorflow.host = get_hostname!() as the third enrichment field in the per-sink VRL remap transform. get_hostname!() is correct infallible VRL syntax.
  • page.tsx: Removes -mb-4 from the dashboard tab bar div, fixing stat card overlap.
  • flow-toolbar.tsx: Fully removes useHasGlobalConfigContent import, the derived state variable, and the absolute-positioned blue dot <span> (also removes the now-unnecessary relative class from the button).
  • pipeline-settings.tsx: Restructures the enrichment toggle to place the label/switch inline and description below; updates description copy to mention .vectorflow.host; adds shrink-0 to chevron and badge in both collapsibles; switches collapsible trigger text from font-semibold to font-medium; removes the exported useHasGlobalConfigContent hook.

Confidence Score: 5/5

  • This PR is safe to merge — all changes are small, targeted UI and YAML generation fixes with no logic regressions or security concerns.
  • All four changes are straightforward: one VRL string append with correct syntax (get_hostname!() is valid infallible VRL), one CSS class removal, and two consistent UI cleanup removals across toolbar and settings. No new logic paths, no auth/data flow changes, no risk of breaking existing behavior.
  • No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Pipeline Graph Nodes and Edges] --> B[generateVectorYaml]
    B --> C{enrichment enabled?}
    C -- No --> D[Raw YAML output]
    C -- Yes --> E[For each sink key]
    E --> F["VRL remap transform source:\n.vectorflow.environment = env\n.vectorflow.pipeline_version = version\n.vectorflow.host = get_hostname!()"]
    F --> G[Inject vectorflow_enrich_SINK transform\nbetween upstream sources and sink]
    G --> H[Enriched YAML output]
    H --> I[Vector Agent receives config]
Loading

Last reviewed commit: 475b4d8

@TerrifiedBug TerrifiedBug merged commit 7e23482 into main Mar 7, 2026
12 checks passed
@TerrifiedBug TerrifiedBug deleted the fix/enrichment-host-and-ui-polish branch March 7, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant