Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new UserTotalSpent entity to track the cumulative amount each user has invested across all IDO pools. The implementation includes schema definition, entity management functions, and comprehensive test coverage.
Key changes:
- Introduces
UserTotalSpententity with user address and total spent tracking - Integrates total spent tracking into the investment flow
- Adds comprehensive tests for single and cross-IDO accumulation scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schema.graphql | Defines the new UserTotalSpent entity schema |
| src/extendedEntities/investProvider.ts | Implements updateUserTotalSpent function for managing user spending totals |
| src/invest-provider.ts | Integrates UserTotalSpent updates into the investment event handler |
| tests/invest-provider.test.ts | Adds comprehensive test coverage for UserTotalSpent functionality |
| assert.fieldEquals("UserIDOInvestment", id, "blockTimestamp", "2000") | ||
|
|
||
| // Test UserTotalSpent accumulation across multiple investments | ||
| let userHex = "0x0000000000000000000000000000000000000002" |
There was a problem hiding this comment.
The hardcoded address string is duplicated from earlier in the test. Consider extracting this as a constant at the top of the test block to improve maintainability and reduce duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #71